"empty" table cells don't include borders in size even when 'empty-cells: show'

RESOLVED FIXED in mozilla1.8alpha6

Status

()

P2
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({css2})

Trunk
mozilla1.8alpha6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch], URL)

Attachments

(1 attachment)

In http://dbaron.org/css/test/intrinsic/block-width-max , the third of the four
boxes is 4 pixels narrower than all the others.  This is because the intrinsic
sizing of the table cells determines that the cell is "empty" (I'm not sure
whether that's correct, but that's another bug) and therefore doesn't add in the
width of the borders.  The code that accounts for cells being smaller because of
lack of borders needs to check the 'empty-cells' property.
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha6
Created attachment 167169 [details] [diff] [review]
patch

Perhaps I should also rename |contentEmptyBeforeReflow| to
|noBorderBeforeReflow|?

Comment 2

14 years ago
Comment on attachment 167169 [details] [diff] [review]
patch

If you like to rename it its OK with me. The whole empty cell code is a
nightmare and needs to be rewritten but thats another story.
Attachment #167169 - Flags: review?(bernd.mielke) → review+
Attachment #167169 - Flags: superreview?(roc) → superreview+
Fix checked in to trunk, 2004-11-30 19:50 -0800.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.