When $^X contains spaces, tests 1 and 3 fail

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Testing Suite
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: Vlad Dascalu, Assigned: Vlad Dascalu)

Tracking

unspecified
Bugzilla 2.16
Bug Flags:
approval +
blocking2.20 +
approval2.18 +
blocking2.18 +
approval2.16 +
blocking2.16.8 +

Details

Attachments

(1 attachment)

v1
1013 bytes, patch
Jouni Heikniemi
: review+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
$^X contains the path of the perl interpreter. I have quite a strange setup and
so it points to "C:\program files\...", so it contains a space.

When $^X contains spaces, tests 1 and 3 fail. Quoting it works on Windows and
Linux (tested).

Only test 1 and 3 contain $^X, so fixing those should do the trick.
(Assignee)

Comment 1

14 years ago
Created attachment 167177 [details] [diff] [review]
v1
Assignee: zach → vladd
Status: NEW → ASSIGNED
(Assignee)

Updated

14 years ago
Attachment #167177 - Flags: review?(jouni)

Comment 2

14 years ago
Comment on attachment 167177 [details] [diff] [review]
v1

r=jouni
Attachment #167177 - Flags: review?(jouni) → review+
(Assignee)

Updated

14 years ago
Flags: blocking2.20?
Flags: blocking2.18?
Flags: blocking2.16.8?
Flags: approval?
Flags: approval2.18?
Flags: approval2.16?
Ya know...  It wouldn't matter what shell it was using if we pass it as
individual parameters, which would make $filename safer, too, even though we
know it won't contain spaces.  The only reason we would have difficulty doing
that there is because of the output redirection.  However, it *is* possible to
redirect output around a shell call from within Perl...

I'm not sure that output redirection syntax is universally valid anyway.  That's
bash/sh syntax, and won't work in csh/tcsh, and I have no clue whether it works
in Windows.
Perl code to redirect STDERR into STDOUT:

open SAVEERR, ">&STDERR"; # save a copy of the stderr handle
# do it twice, just to kill the "used only once" warning
open SAVEERR, ">&STDERR";
open STDERR, ">&STDOUT";
#
# do system call here
#
open STDERR, ">&SAVEERR"; # restore the original stderr
(Assignee)

Comment 5

14 years ago
BTW, I requested blocking because this kinda blocks development on Windows in
some situations like mine :-)
Flags: blocking2.20?
Flags: blocking2.20+
Flags: blocking2.18?
Flags: blocking2.18+
Flags: blocking2.16.8?
Flags: blocking2.16.8+
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval2.16?
Flags: approval2.16+
Flags: approval+
Target Milestone: --- → Bugzilla 2.16
(Assignee)

Comment 6

14 years ago
Checking in t/001compile.t;
/cvsroot/mozilla/webtools/bugzilla/t/001compile.t,v  <--  001compile.t
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in t/003safesys.t;
/cvsroot/mozilla/webtools/bugzilla/t/003safesys.t,v  <--  003safesys.t
new revision: 1.4.2.1; previous revision: 1.4
done

Checking in t/001compile.t;
/cvsroot/mozilla/webtools/bugzilla/t/001compile.t,v  <--  001compile.t
new revision: 1.10.4.1; previous revision: 1.10
done
Checking in t/003safesys.t;
/cvsroot/mozilla/webtools/bugzilla/t/003safesys.t,v  <--  003safesys.t
new revision: 1.5.4.1; previous revision: 1.5
done

Checking in t/001compile.t;
/cvsroot/mozilla/webtools/bugzilla/t/001compile.t,v  <--  001compile.t
new revision: 1.11; previous revision: 1.10
done
Checking in t/003safesys.t;
/cvsroot/mozilla/webtools/bugzilla/t/003safesys.t,v  <--  003safesys.t
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.