Closed
Bug 272033
Opened 20 years ago
Closed 20 years ago
nsComputedDOMStyle.cpp has too many side switches
Categories
(Core :: DOM: CSS Object Model, defect, P3)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha6
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: memory-footprint, Whiteboard: [patch])
Attachments
(1 file)
7.11 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I added some functions to nsStyleSides to allow avoiding per-side switches a while ago. nsComputedDOMStyle.cpp should use them.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha6
Assignee | ||
Updated•20 years ago
|
Attachment #167212 -
Flags: superreview?(bzbarsky)
Attachment #167212 -
Flags: review?(bzbarsky)
Comment 2•20 years ago
|
||
Comment on attachment 167212 [details] [diff] [review] patch >Index: nsComputedDOMStyle.cpp >+#define NS_OPPOSITE_SIDE(s_) ((s_ + 2) & 3) Make that: #define NS_OPPOSITE_SIDE(s_) (((s_) + 2) & 3) (Note parens around "s_"). r+sr=bzbarsky
Attachment #167212 -
Flags: superreview?(bzbarsky)
Attachment #167212 -
Flags: superreview+
Attachment #167212 -
Flags: review?(bzbarsky)
Attachment #167212 -
Flags: review+
Assignee | ||
Comment 3•20 years ago
|
||
Fix checked in to trunk, 2004-11-29 21:31 -0800.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•