Pressing F9 key causes mail to be checked

RESOLVED FIXED

Status

www.mozilla.org
General
--
trivial
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: Cédric Corazza, Assigned: Magnus Melin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

4.25 KB, patch
Steffen Wilberg
: review+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0

When pressing the F9 key, it causes the mail to be checked for the focussed
account. (Note: F9 is the shortcut in Lotus Notes to check for new mails). This
also occurred with TB 0.8. This shortcut is not documented as far as I know

Reproducible: Always
Steps to Reproduce:
1.Launch TB
2.Select any folder on any account
3.Press F9 key

Actual Results:  
The same result as if you click on the "Get mail" button on the toolbar

Expected Results:  
None

Updated

14 years ago
Status: UNCONFIRMED → NEW
Component: General → Help Documentation
Ever confirmed: true
(Assignee)

Updated

12 years ago
Assignee: mscott → djst.mozilla
(Assignee)

Comment 1

12 years ago
Created attachment 222775 [details] [diff] [review]
proposed fix
(Assignee)

Updated

12 years ago
Attachment #222775 - Flags: review?(djst.mozilla)
QA Contact: help-documentation

Comment 2

11 years ago
Comment on attachment 222775 [details] [diff] [review]
proposed fix

It's F9 on Linux and Mac (XP_UNIX is true on Mac as well), but F5 on Windows: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mail/base/content/mailWindowOverlay.xul&rev=1.116.2.76&mark=376-385#376

The document uses classes like kb_wl, kb_h, kb_m etc. to display platform-specific keys. Somebody should add a comment explaining those classes.
Attachment #222775 - Flags: review?(djst.mozilla) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 267265 [details] [diff] [review]
proposed fix, v2
Assignee: djst.mozilla → mkmelin+mozilla
Attachment #222775 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #267265 - Flags: review?(steffen.wilberg)
(Assignee)

Updated

11 years ago
Attachment #267265 - Attachment description: proposed additional fix, v2 → proposed fix, v2
(Assignee)

Updated

11 years ago
OS: Linux → All
Hardware: PC → All

Comment 4

11 years ago
Comment on attachment 267265 [details] [diff] [review]
proposed fix, v2

That's quite nice. But if only the Windows keys are displayed, there's an empty line between "Ctrl+T" and "F5". You need to move the <br> into one of those <span>s.

And please split up that long line after the <br>s; 379 characters is a bit too long ;-)
Attachment #267265 - Flags: review?(steffen.wilberg) → review-
(Assignee)

Comment 5

11 years ago
Created attachment 267812 [details] [diff] [review]
proposed fix, v3

Addressing review comments.
Attachment #267265 - Attachment is obsolete: true
Attachment #267812 - Flags: review?(steffen.wilberg)

Comment 6

11 years ago
Comment on attachment 267812 [details] [diff] [review]
proposed fix, v3

Great! r=me.
Attachment #267812 - Flags: review?(steffen.wilberg) → review+

Updated

11 years ago
Component: Help Documentation → www.mozilla.org
Product: Thunderbird → mozilla.org
QA Contact: help-documentation → www-mozilla-org
Version: unspecified → other

Comment 7

11 years ago
> No newline at end of file
Fixed those and checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.