272052 - Pressing F9 key causes mail to be checked

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Cédric Corazza]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.5) Gecko/20041108 Firefox/1.0

When pressing the F9 key, it causes the mail to be checked for the focussed
account. (Note: F9 is the shortcut in Lotus Notes to check for new mails). This
also occurred with TB 0.8. This shortcut is not documented as far as I know

Reproducible: Always
Steps to Reproduce:
1.Launch TB
2.Select any folder on any account
3.Press F9 key

Actual Results:  
The same result as if you click on the "Get mail" button on the toolbar

Expected Results:  
None

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 2

[Steffen Wilberg]

Comment on attachment 222775 [details] [diff] [review]
proposed fix

It's F9 on Linux and Mac (XP_UNIX is true on Mac as well), but F5 on Windows: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mail/base/content/mailWindowOverlay.xul&rev=1.116.2.76&mark=376-385#376

The document uses classes like kb_wl, kb_h, kb_m etc. to display platform-specific keys. Somebody should add a comment explaining those classes.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Comment 4

[Steffen Wilberg]

Comment on attachment 267265 [details] [diff] [review]
proposed fix, v2

That's quite nice. But if only the Windows keys are displayed, there's an empty line between "Ctrl+T" and "F5". You need to move the <br> into one of those <span>s.

And please split up that long line after the <br>s; 379 characters is a bit too long ;-)

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v3

Addressing review comments.

Comment 6

[Steffen Wilberg]

Comment on attachment 267812 [details] [diff] [review]
proposed fix, v3

Great! r=me.

Comment 7

[Steffen Wilberg]

> No newline at end of file
Fixed those and checked in.