272109 - In <tree.xml>, "Error: this.view has no properties"

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE)

{{
Error: this.view has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 0
}}

Steps:
1. "Have" Dowload Manager, with a list of only one item
2. Select the item
3. Press Alt-R to remove the file

R. The file is removed as expected, but there should be no error.

Note: No bug if using the mouse to click on the menu button...

Comment 1

[[e-mail]]

Nice one... when you remove the last download the view gets deleted too :-(

Comment 2

[Asa Dotzler [:asa]]

Is this a regression? If so, do we know what change caused this or approximately
when it regressed?

Comment 3

[[e-mail]]

This isn't supposed to happen, see bug 257671. If you can still reproduce it in
trunk, start Venkman, don't exclude browser files, break on exceptions, then hit
ALT+R, and hopefully you'll end up somewhere more meaningful than line 0, or if
not, maybe you can step out to the caller and find something useful there.

Comment 4

[Florian Quèze [:florian]]

[Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050105]
Venkman stops at line 479:

Error ``this.view has no properties'' [xs] in file
``chrome://global/content/bindings/tree.xml'', line 0, character 0.
Exception ``TypeError: this.view has no properties'' thrown from function
onxblkeypress(event=KeyboardEvent:{0}) in
<chrome://global/content/bindings/tree.xml> line 479.
[e] message = [string] "this.view has no properties"
Stopped for thrown exception.
#0: function onxblkeypress(event=KeyboardEvent:{0}) in
<chrome://global/content/bindings/tree.xml> line 479
477: <handler event="keypress">
478: <![CDATA[
479: var c = this.currentIndex;
480: if (event.keyCode == ' '.charCodeAt(0)) {
481: if (!this.view.selection.isSelected(c))

Comment 5

[[e-mail]]

Aha, well in that case it's a generic tree issue, not a downloadmanager issue.
To reproduce, open the URL link, click in the tree, press any key.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> To reproduce, open the URL link, click in the tree, press any key.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041217]

Click on top bar named "Blank":
{{
Error: this.parentNode.parentNode.treeBoxObject.view has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 996
}}

Click in "empty" body/tree, then press a key:
{{
Error: this.treeBoxObject.selection has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 0
}}

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107
Firefox/1.0]

Both action work fine: no error.

This bug seems to be MozillaAS (Trunk and v1.7.x) only bug, not FireFox,
if this can help.

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041217]

JS.D. traces: (confirming)

Click on top bar named "Blank":
{{
Exception ``TypeError: this.parentNode.parentNode.treeBoxObject.view has no
properties'' thrown from function onxblclick(event=Event:{0}) in
<chrome://global/content/bindings/tree.xml> line 996.
[e] message = [string] "this.parentNode.parentNode.treeBoxObject.view has no
properties"
Stopped for thrown exception.
#0: function onxblclick(event=Event:{0}) in
<chrome://global/content/bindings/tree.xml> line 996
994:
995: <handlers>
996: <handler event="click" button="0" phase="target"
action="this.parentNode.parentNode.treeBoxObject.view.cycleHeader(this.id, this);"/>
997: </handlers>
998: </binding>
}}

Click in "empty" body/tree, then press a key:
{{
Exception ``TypeError: this.treeBoxObject.selection has no properties'' thrown
from function onxblkeypress(event=Event:{0}) in
<chrome://global/content/bindings/tree.xml> line 587.
[e] message = [string] "this.treeBoxObject.selection has no properties"
Stopped for thrown exception.
#0: function onxblkeypress(event=Event:{0}) in
<chrome://global/content/bindings/tree.xml> line 587
585: <handler event="keypress">
586: <![CDATA[
587: var c = this.currentIndex;
588: if (event.keyCode == ' '.charCodeAt(0)) {
589: if (!this.treeBoxObject.selection.isSelected(c))
}}

Comment 8

[[e-mail]]

FireFox disables chrome errors by default:
http://lxr.mozilla.org/seamonkey/source/browser/app/profile/firefox.js#217

Comment 9

[Florian Quèze [:florian]]

With firefox 1.0, I have the errors in comment 7

With mozilla : [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6)
Gecko/20050105]

Click on top bar named "Blank":
Error ``tree.columns has no properties'' [xs] in file
``chrome://global/content/bindings/tree.xml'', line 874, character 0.
Stopped for error handler.
#0: function onxblclick(event=MouseEvent:{0}) in
<chrome://global/content/bindings/tree.xml> line 874
872: <![CDATA[
873: var tree = this.parentNode.parentNode;
874: var column = tree.columns.getColumnFor(this);
875: tree.view.cycleHeader(column);
876: ]]>

Click in "empty" body/tree, then press a key:
Error ``this.view has no properties'' [xs] in file
``chrome://global/content/bindings/tree.xml'', line 0, character 0.
Exception ``TypeError: this.view has no properties'' thrown from function
onxblkeypress(event=KeyboardEvent:{0}) in
<chrome://global/content/bindings/tree.xml> line 479.
[e] message = [string] "this.view has no properties"
Stopped for thrown exception.
#0: function onxblkeypress(event=KeyboardEvent:{0}) in
<chrome://global/content/bindings/tree.xml> line 479
477: <handler event="keypress">
478: <![CDATA[
479: var c = this.currentIndex;
480: if (event.keyCode == ' '.charCodeAt(0)) {
481: if (!this.view.selection.isSelected(c))

Comment 10

[Florian Quèze [:florian]]

With a recent nightly of firefox (Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8a6) Gecko/20050105 Firefox/1.0+), I get the same errors as the
errors I got with a nightly of Mozilla (see comment 9)

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107
> Firefox/1.0]
> 
> Both action work fine: no error.
> 
> This bug seems to be MozillaAS (Trunk and v1.7.x) only bug, not FireFox,
> if this can help.

(In reply to comment #8)
> FireFox disables chrome errors by default:
> http://lxr.mozilla.org/seamonkey/source/browser/app/profile/firefox.js#217

Ah...

Then, I get the same errors in FF10: lines 992 and 0.

Then it's a true Core bug ;-<

Comment 12

[Florian Quèze [:florian]]

Attachment: patch

Comment 13

[Florian Quèze [:florian]]

Comment on attachment 170597 [details] [diff] [review]
patch

It's probably bitrotted and I think one of the reviewer told me on IRC that it wasn't the right approach to fix this.

Comment 14

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

Bug still there, per comment 5 testcase:
{{
Error: this.view has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 771
}}

*(OS) Windows 98 -> Windows 2000, as I'm not using W98 anymore.

Comment 15

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007110203 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Bug still there, per comment 5 testcase:

When clicking in the tree = every time the tree gets focus actually:
{{
Security Error: Content at chrome://global/content/bindings/tree.xml may not load data from https://bugzilla.mozilla.org/show_bug.cgi?id=272109.

Error: this.view has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 635
}}

When pressing a key:
{{
Security Error: Content at chrome://global/content/bindings/tree.xml may not load data from https://bugzilla.mozilla.org/show_bug.cgi?id=272109.

Error: this.view has no properties
Source File: chrome://global/content/bindings/tree.xml
Line: 807
}}

Comment 16

[Serge Gautherie (:sgautherie)]

'blocking1.9=?':
It would be nice if Toolkit did not generate errors.

Comment 17

[:aceman]

These errors are still visible, at least in Thunderbird 14.

Comment 18

[Jan Varga [:janv]]

I don't think anyone is going to work on this given the plan to remove the XUL "tree" widget (bug 1446335).