Menu doesn't update "Open in Tabs" when adding or deleting items in manager

RESOLVED FIXED

Status

--
major
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Create a new folder in bookmark manager in the bookmark menu
put an item in it

expected:
should have "open in tabs" in the menu

actual:
it doesn't until a restart

basically i wasn't correctly watching for add/remove notifications from the bm
manager code. Fix upcoming that should go on the branch.
(Assignee)

Comment 1

14 years ago
Created attachment 167258 [details] [diff] [review]
fix

this fixes it and moves a bit of code around to reuse it. it's simpler than the
patch implies.

josh? geoff? can you give this a gander asap since it needs to go on the branch
too?
(Assignee)

Updated

14 years ago
Blocks: 261393
Comment on attachment 167258 [details] [diff] [review]
fix

Works fine.
Attachment #167258 - Flags: review+
(Assignee)

Comment 4

14 years ago
landed on trunk. will close when i land on branch tomorrow at work.
Status: NEW → ASSIGNED
(Assignee)

Comment 5

14 years ago
landed on branch
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.