272117 - Menu doesn't update "Open in Tabs" when adding or deleting items in manager

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Create a new folder in bookmark manager in the bookmark menu
put an item in it

expected:
should have "open in tabs" in the menu

actual:
it doesn't until a restart

basically i wasn't correctly watching for add/remove notifications from the bm
manager code. Fix upcoming that should go on the branch.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: fix

this fixes it and moves a bit of code around to reuse it. it's simpler than the
patch implies.

josh? geoff? can you give this a gander asap since it needs to go on the branch
too?

Comment 2

[Ludovic Hirlimann [:Usul]]

Comment on attachment 167258 [details] [diff] [review]
fix

Works fine.

Comment 3

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 167258 [details] [diff] [review]
fix

this works fine and looks ok. r=[e-mail]

Comment 4

[Mike Pinkerton (not reading bugmail)]

landed on trunk. will close when i land on branch tomorrow at work.

Comment 5

[Mike Pinkerton (not reading bugmail)]

landed on branch