272150 - Attempts to rebuild cvs history on specific directories are ignored

Status: VERIFIED FIXED

(Webtools Graveyard :: Bonsai, defect, P1)

Description

[Dave Miller [:justdave]]

The rebuild form looks like this:

Ignore checkins earlier than:
Ignore files before (must be full path starting with /cvsroot; leave blank to do
everything):
Only do files within the subdirectory of /cvsroot named:

The "Only do files within the subdirectory" line is completely ignored.  No
matter what you put there, it still attempts to do everything (which currently
doesn't work, either, as it timed out after 8 or so hours, but that's another bug)

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

removed some unused variables, changed the code around so it actually does what
the form says it's doing.

Comment 2

[Dave Miller [:justdave]]

this is live and tested on bonsai.m.o, and at first glance, appears to work
quite well.

Comment 3

[Dave Miller [:justdave]]

Been a long time since I've done Bonsai stuff, does the review+ mean I can check
it in? :)

/me wonders if the patch has bitrotted

Comment 4

[timeless]

yes

Comment 5

[Dave Miller [:justdave]]

wasn't bitrotted.

Checking in rebuildcvshistory.cgi;
/cvsroot/mozilla/webtools/bonsai/rebuildcvshistory.cgi,v  <--  rebuildcvshistory.cgi
new revision: 1.12; previous revision: 1.11
done