Last Comment Bug 272167 - nsIWindowsRegistry::getRegistryEntry does not support non-latin1 keys/values
: nsIWindowsRegistry::getRegistryEntry does not support non-latin1 keys/values
Status: RESOLVED FIXED
: intl
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: unspecified
: x86 Windows 2000
-- normal (vote)
: ---
Assigned To: Jungshik Shin
:
:
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on: mzlu
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-28 14:54 PST by Christian :Biesinger (don't email me, ping me on IRC)
Modified: 2008-07-31 04:22 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch to get rid of it (5.63 KB, patch)
2005-05-21 23:00 PDT, Jungshik Shin
cbiesinger: review+
darin.moz: superreview+
shaver: approval1.8b3+
Details | Diff | Splinter Review

Description User image Christian :Biesinger (don't email me, ping me on IRC) 2004-11-28 14:54:53 PST
[filing here for lack of a better component]

seamonkey version of bug Bug 272166

231                    string getRegistryEntry( in long aHKeyConstant, in string
aSubKeyName, in string aValueName );

This means that only latin1 is supported. Worse, on a non-latin1 (guess that's
really a non-windows1252) system, the characters will be interpreted as latin1,
likely leading to garbage for non-ascii characters.

this should use wstring or AString in the IDL.
Comment 1 User image Jungshik Shin 2005-05-21 23:00:41 PDT
Created attachment 184219 [details] [diff] [review]
patch to get rid of it 

there's no consumer. we can just rid of it.
Comment 2 User image neil@parkwaycc.co.uk 2005-05-22 02:27:19 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

>-#define NS_IWINDOWSHOOKS_CONTRACTID    "@mozilla.org/winhooks;1"
>-#define NS_IWINDOWSHOOKS_CLASSNAME "Mozilla Windows Integration Hooks"
I don't think you meant to delete these, did you?
Comment 3 User image Jungshik Shin 2005-05-22 02:46:23 PDT
You're right. I mistakendly thought they're for nsIWindowsRegistry. Thanks for
catching it.
Comment 4 User image Christian :Biesinger (don't email me, ping me on IRC) 2005-05-22 06:05:47 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

I'm not sure that we should remove this. extensions may well be using it, and
in fact are (see google results for nsiwindowsregistry)

maybe it's ok now that we have bug 292981's nsIWindowsRegKey...
Comment 5 User image Darin Fisher 2005-05-23 12:53:41 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

I say remove it, and encourage extensions to use the new interface.  The old
interface is not unicode-safe.
Comment 6 User image Christian :Biesinger (don't email me, ping me on IRC) 2005-05-23 13:48:51 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

ok, then. r=biesi with what neil said.
Comment 7 User image Jungshik Shin 2005-05-23 18:49:50 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

thanks for r/sr.

asking for a of trunk landing. this is a low risk patch except that a couple of
extensions use this interface. We have to release-note this (the draft is
available in bug 272166.) I'll modify it for mozilla suite (there's a little
difference).
Comment 8 User image Mike Shaver (:shaver -- probably not reading bugmail closely) 2005-06-01 11:38:21 PDT
Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

a=shaver
Comment 9 User image Jungshik Shin 2005-06-01 17:00:00 PDT
fix just landed

Note You need to log in before you can comment on or make changes to this bug.