272171 - Add "Unblock this website" in the Camino menu + keyboard shortcut.

Status: VERIFIED WONTFIX

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Jasper]

We should allow the user to have a simple way to block or unblock the website
with either a menu item (we have that in the statusbar) but also in the Camino
menu and with a keyboard shortcut.

I have noticed that a lot of users are not aware of the fact that 1) camino has
a whitelist, 2) expect a turn pop-up block of like in safari, 3) or not aware of
the fcat that the status bar popup icon has a menu.

I also want to note that if we add this functionality it would be good because
it would also allow us to hide the status bar savely while keeping all
functionality.

Comment 1

[Samuel Sidler (old account; do not CC)]

Bump.

I'm not concerned about the keyboard shortcut or the whitelist so much as the
menu item.

Camino should have a menu item in the application menu that's called "Enable
Pop-up Blocking" when blocking is disabled and "Disable Pop-up blocking" when
blocking is enabled. In addition, *this* should have a keyboard shortcut (is
command + k in use? That's what Safari's is, I believe).

Comment 2

[Mike Pinkerton (not reading bugmail)]

i don't want to add "enable/disable" as it's generally not what the user wants.
what they want is to add the current site to the whitelist, not turn off popup
blocking wholesale.

we should make "unblock this website" more visible somehow i guess.

Comment 3

[Josh Aas]

might be nice for 0.9, but it should not block the release

Comment 4

[Samuel Sidler (old account; do not CC)]

(In reply to comment #3)
> might be nice for 0.9, but it should not block the release

Target for 1.1?

Comment 5

[Samuel Sidler (old account; do not CC)]

Should we possibly not call the item "Unblock this website". That makes it sound
like the entire site is blocked when only pop-ups are.

How about "Allow pop-ups on this site" or something similar.

Comment 6

[Mike Pinkerton (not reading bugmail)]

*** Bug 245413 has been marked as a duplicate of this bug. ***

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 188194 has been marked as a duplicate of this bug. ***

Comment 8

[froodian (Ian Leue)]

Is this really still necessary with the obvious popup blocker?

Comment 9

[froodian (Ian Leue)]

Per IRC, it is for accessability if nothing else.  Taking.

Comment 10

[froodian (Ian Leue)]

Attachment: Patch

This is waiting on bug 181712 to clear up the nib, so I'm not requesting review yet, just uploading so I can clean it off my tree.  This does as advertised (the same as the "unblock" button on the pop-up blocker).  The only thing I do that I'm not completely sure about is clearing mBlockedSites after unblocking (either way).  This is necessary since we now have two UI outlets, and we don't want to let the user try to unblock the same pop-ups (especially since it doesn't work).  Also, we need some way to invalidate the menu item after it's done.  I'm pretty sure it doesn't do anything bad, since the only thing it's used for is holding the pop-ups to unblock them, and if we've just unblocked them...

For the nib, I was going with "Allow Site's Pop-ups".  It's not amazing, but it's short enough, and describes the action.  If anybody has anything better, I'm all ears.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

What about sites that generate multiple popups some time after each other (e.g., cnn.com)?

Comment 12

[Håkan Waara]

If we want this menuitem at all (even when we already have the big popup blocker bar), I think the menuitem should be hidden (not disabled) if there are no blocked popups.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Why exactly do we want this?

And if we do want this (which I'm not convinced we do), *hiding* it when it's not applicable is a terrible idea.  That's not the way Mac OS X works, and it'll make sure the menu item is never noticed by anyone.

If it's for a11y reasons, hwaara has pointed out several times before that there are other tools available to help make the UI accessible; not everything has to have a keyboard shortcut to be accessible.

Comment 0 points 1 and 3 are UI issues we need to address with our pop-up blocking UI, but a disconnected menu item is not the right way to do it.

Comment 14

[froodian (Ian Leue)]

Sure, there are other a11y tools... but this is also for regular old keyboard people IMO... (ie me).  That said, I'm not married to it (hence comment 8)

Comment 15

[Håkan Waara]

I vote for wontfix. Since we already have lots of UI for this feature, I don't think it's used often enough to also warrant a menuitem.

Comment 16

[froodian (Ian Leue)]

This is WONTFIX in favor of bug 346803 per IRC.