272199 - Cannot reconvert with Japanist(Japanese IME) on WinNT

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On NT, we cannot reconvert with Japanist.
Because Japanist need Unicode string, but Mozilla send CP932 string.

On NT, window of Mozilla is Unicode window. Therefore, on unicode window,
we should send unicode string when reconvert.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

I tested with MS-IME2000/ATOK17/Japanist2003 on Win2000/WinME.

Comment 2

[Ere Maijala (slow)]

Comment on attachment 167323 [details] [diff] [review]
Patch

How about adding nsToolkit::mIsNT to the calls to OnIMERequest instead of the
default parameter? I just find this a little bit unusual way of using a default
parameter. I'd actually rather remove the default  altogether and add the
parameter to all calls (there aren't many).

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 4

[Ere Maijala (slow)]

Comment on attachment 168004 [details] [diff] [review]
Patch

r=ere

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 168004 [details] [diff] [review]
Patch

sr=bzbarsky

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ere:

Please check-in the patch.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 168004 [details] [diff] [review]
Patch

The risk of this patch is low. But this problem is 'major'.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 168004 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.8a6.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Jungshik:

Could you check-in the patch?

Comment 10

[Jungshik Shin]

fix checked in.