272250 - make distclean from mozilla does not clean mozilla/camino/build

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Ludovic Hirlimann [:Usul]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041001 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041001 Camino/0.8+

Wanting to distclean because I'm changing from a static build to a shared build
I noticed that mozilla/camino/build directory is not cleaned.

Reproducible: Always
Steps to Reproduce:
1. Build Camino
2. make -f client.mk distclean or make clean


Actual Results:  
mozilla/camino/build still contained the pref bundles and the Camino.app

Expected Results:  
the build directory should be empty.

Comment 1

[Mike Pinkerton (not reading bugmail)]

-> bsmedberg

Comment 2

[Ludovic Hirlimann [:Usul]]

Assigning to bsmedberg as per our irc conversation. ccing mike and josh as they
lead the team. Targeting for 0.9

Comment 3

[Benjamin Smedberg]

Attachment: Add dist/camino to GARBAGE_DIRS

Comment 4

[Mike Pinkerton (not reading bugmail)]

i think that should be camino/build, camino doesn't put anything into dist.

Comment 5

[Josh Aas]

I don't think this is a problem any more. Seems like it never was. Reopen if you
can reproduce with exact steps.

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> I don't think this is a problem any more. Seems like it never was. Reopen if you
> can reproduce with exact steps.

make -f client.mk build
make -f distclean 

build directory is present and should not be.

Comment 7

[Benjamin Smedberg]

Josh, this is in fact very simple. Just add "distclean" to the "clean clobber"
targets in camino/Makefile.in.

Of course, switching to use the GARBAGE var would avoid this kind of mistake in
the future ;)

Comment 8

[Mike Pinkerton (not reading bugmail)]

ludo, can you verify the patch works?

Comment 9

[Ludovic Hirlimann [:Usul]]

(In reply to comment #8)
> ludo, can you verify the patch works?

Does not apply correctly. I'll upload a tested patch that applies.

Comment 10

[Ludovic Hirlimann [:Usul]]

Attachment: make distclean work

setting r+ since i did not wrote the patch.

Comment 11

[Benjamin Smedberg]

Comment on attachment 169383 [details] [diff] [review]
make distclean work

I was guessing about $(DIST)/camino. Does such a thing even exist?

Comment 12

[Josh Aas]

> I was guessing about $(DIST)/camino. Does such a thing even exist?

No, AFAIK.

Why are you removing this line:
> rm -f resources/localized/English.lproj/Localized.rsrc
but not adding something else to remove that file?

Comment 13

[Ludovic Hirlimann [:Usul]]

(In reply to comment #12)

> 
> Why are you removing this line:
> > rm -f resources/localized/English.lproj/Localized.rsrc
> but not adding something else to remove that file?
Because that file is static to me and not build, it's being co directly from cvs.

Comment 14

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 169383 [details] [diff] [review]
make distclean work

$(DIST)/camino doesn't exist.

Comment 15

[Ludovic Hirlimann [:Usul]]

Attachment: Adressing pink's comment.

Asking review to josh.

Comment 16

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 169648 [details] [diff] [review]
Adressing pink's comment.

sr=pink

Comment 17

[Mike Pinkerton (not reading bugmail)]

landed on trunk.