272272 - enable review flags on attachments in mozilla.org product

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[fantasai]

Patches and new documents in the mozilla.org component frequently go through
review, which is currently being handled the old-fashioned-way in comments. It'd
be nicer if we could flag review?/+/- on them as in other components.

See, for example, bug 243369

Comment 1

[Asa Dotzler [:asa]]

fantasia, do we need this for all components within the mozilla.org Product or
are there specific components that need the flag?  Also, will there be cases
where you all will want more than one review flag in a bug?

Comment 2

[fantasai]

Asa, I think just the webmaster component will be fine. I don't think we need
dual review except in rare cases, so just review flags would be sufficient; no sr.
Not so sure about approval flags. dbaron? Do we want those available?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

probably just review would be fine

Comment 4

[gekacheka]

Patches to bugzilla.mozilla.org that need review currently can't be flagged and may be forgotten or overlooked because there is no flag, such as Gerv's patch for bug 308943 and bug 308950 (attached to bug 308950).

Comment 5

[Gervase Markham [:gerv]]

The mozilla.org product/Bugzilla: Other b.m.o issues component (i.e. the one in which this bug sits) now has a review flag. However, we don't have one for other components in the mozilla.org product.

Which other components would you like? "www.mozilla.org"?

Gerv

Comment 6

[fantasai]

Yes, please :)

Comment 7

[Reed Loden [:reed]]

I've been bitten by the fact that mozilla.org doesn't have review flags many times. I'll enable it for the entire product.

Comment 8

[Reed Loden [:reed]]

Done. For reference, these components used to be the only ones with the flag in mozilla.org: Build & Release, Bugzilla: Other bmo Issues, Tinderbox Configuration, Tinderbox Platform, and www.mozilla.org. Now, all components under mozilla.org have the review flag for attachments.