272321 - action should default to edit in editproducts.cgi if a product is passed without an action

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

steps:
1. log out
2. visit url https://bugzilla.mozilla.org/editproducts.cgi?product=mozilla.org
3. log in (because you have to)
3' expect to reach:
https://bugzilla.mozilla.org/editproducts.cgi?product=mozilla.org
3` actually reach: https://bugzilla.mozilla.org/editproducts.cgi

Comment 1

[timeless]

ok, it seems the cgi expects &action=edit, that's unreasonable, please consider
this a request to infer that.

Comment 2

[Dave Miller [:justdave]]

Sounds reasonable to me.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

A nice side effect is that it fixes bug 258777 too. :)

Note that editproducts.cgi needs some cleanup. This will be done in bug 286294.

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 178168 [details] [diff] [review]
patch, v1

Good as is. Works.

>Index: editproducts.cgi
>-unless ($action) {
>+unless ($action || $product) {

Nit, tinted by personal taste: this stretches the |unless| a little too far
imho... I think it reads better as |if (!$action && !$product)| or |if
(!($action || $product))|. You could do me a favour fixing this on checkin :)

This fixes bug 258777 in a different way than I expected. You find the
classification by product name, so your fix implies that product names are
unique accross classifications. This is currently required anyway, so I'm fine
with it. Approver?

Comment 5

[Frédéric Buclin]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.77; previous revision: 1.76
done