272411 - calDateTime.jsDate doesn't handle timezones correctly

Status: VERIFIED WORKSFORME

(Calendar :: Internal Components, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Now that I fixed .jsDate:

js> b.jsDate = new Date()
Tue Nov 30 2004 08:18:16 GMT-0500 (UTC)
js> b.jsDate
Thu Dec 30 2004 13:18:16 GMT-0500 (UTC)

Looks like it's giving me back GMT, but not changing the timezone to GMT-0000. 
Or something.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 272411-libical-timezone-horkage-0.patch

putenv("TZ=") doesn't do what is really wanted here.  The latest version of
libical uses putenv("TZ"), which should (I think) work.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

though I just not realize that this patch won't fix the bug you report here;
that's a separate (shortly-to-be-fixed) issue

Comment 3

[Mostafa Hosseini]

Comment on attachment 167584 [details] [diff] [review]
272411-libical-timezone-horkage-0.patch

It might be a good time to update libical altogether to their latest and
greatest from cvs,( Bug 237302 ), preserving our patches of course.

Comment 4

[Bas van den Bosch]

Is this still valid?

Comment 5

[:Hb]

WORKSFORME

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Verified with todays nightly builds.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Test - v1

The test is quite simple. It uncovered that we don't save milliseconds in calIDateTime, but I don't think thats a must.

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 414004 [details] [diff] [review]
Test - v1

r=mschroeder

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Test checked in on cc rev d31389c77e0c and c191 rev b1e0280e9865