272455 - javascript statement "prompt(string)" fails with the latest nightly of TB or Fx 1.0.1

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[intendentedelleacque]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows 98; Win 9x 4.90; Virgilio3pc)
Build Identifier: 

I'm writing an extension that uses the javascript function "prompt(string)".
It works perfectly in TB 0.9, but with the latest nightly (20041130) the 
execution fails and in the javascript console I find this error:
uncaught exception: [Exception... "Component returned failure code: 0x80004005 
[nsIDOMJSWINDOW.prompt]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)".
With the nightly it happens every time I call "prompt(string)" in a javascript 
script.
If you want to try, the extension is here: http://nic-nac-
project.de/~kaosmos/profilepass-0.1.xpi


Reproducible: Always
Steps to Reproduce:
1. install an extension that has a javascript script with the 
instruction "prompt(string)"
2. launch thunderbird and try to use the extension
3. in tools --> javascript console you'll find the errore above about "prompt"

Actual Results:  
The javascript fails, because of the error with "prompt(string)"

Expected Results:  
The function "prompt(string)" should show a javascript prompt, as happens with 
the 0.9 version

The bug happens with a new installation, without no additional themes and no 
other extensions.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I see this too, and it happens in the latest nightlies as well.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

A workaround is to invoke the prompt service as in the following code snippet:

http://lxr.mozilla.org/mozilla/source/calendar/resources/content/pref/calendarPref.xul#115

Comment 3

[intendentedelleacque]

(In reply to comment #2)
> A workaround is to invoke the prompt service as in the following code snippet:
> 
>
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/pref/calendarPref.xul#115
> 

Thank you for the hint, anyway I've just been using that method, but I wanted to
submit the problem because I think that it's a small (?) bug.

Comment 4

[Johnny Stenback (:jst)]

*** Bug 282341 has been marked as a duplicate of this bug. ***

Comment 5

[Johnny Stenback (:jst)]

Attachment: Fix. Use the window watcher directly to get an nsIAuthPrompt

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 177575 [details] [diff] [review]
Fix. Use the window watcher directly to get an nsIAuthPrompt

sr=dveditz,a=dveditz

Comment 7

[Johnny Stenback (:jst)]

Fixed on the aviary branch.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Doesn't this affect seamonkey 1.7 too?  If so, this needs to land there.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Actually, it changes stuff in gecko so it does need to land there.  Please make
it so.  a=caillon.

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 177575 [details] [diff] [review]
Fix. Use the window watcher directly to get an nsIAuthPrompt

r=caillon, too.  fwiw.

Comment 11

[Johnny Stenback (:jst)]

Fix landed on the trunk now too. Marking FIXED.

Comment 12

[Scott MacGregor]

this has been ported to the AVIARY_1_0_20040515_BRANCH. This does not mean that
it's actually fixed in the 1.0 release of course.