27247 - Buttons appear cut, also tab headings, etc.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[shrirang khanzode]

Used today's commercial build on MAC. 2000021008

1.Install and launch the browser
2.Select menu option Tasks->My Wallet->Wallet Contents
3.Observe the 'Wallet Editor' window open up.
4.'OK' and 'CANCEL' buttons at the bottom-right hand side appear partially cut.

Expected Result: Buttons should appear fully.

Comment 1

[Mike Pinkerton (not reading bugmail)]

So very not a menu bug. Reassigning to morse.

Comment 2

[Stephen P. Morse]

So it's a dialog bug.  Reassigning to xpapp.

Comment 3

[sairuh (rarely reading bugmail)]

yep, still a problem using the mac comm bits from 2000-02-11-12...then again 
that's the latest build for mac. ;-(

but when checking out, say, the Wallet editor on winNT and linux (2000-02-14-08 
comm bits), i don't seem to see clipped buttons. that dialog at least looks fine 
now... shrir, d'you see the problem anywhere else?

Comment 4

[Paul MacQuiddy]

changing qa contact to [e-mail] on some random bugs

Comment 5

[John Morrison]

qa -> shrir ... is this fixed??

Comment 6

[shrirang khanzode]

Not really. If I do Tasks->Personal Managers->Password Manager->View Stored 
Passwords, the OK button appears cut partially.

Comment 7

[leger]

Moving nsbeta2 nomination from Status Summary to Keywords field.  This is where 
the nomination belongs.  NOT Status Summary...my query won't pick it up that 
way.

Comment 8

[leger]

Is this on OS 9 only?  What about 8.x..can we get a screenshot?

Comment 9

[sairuh (rarely reading bugmail)]

sounds like this is related/perhaps a dup of the bug dealing w/minimum dialog
size, bug 34200.

Comment 10

[Stephen P. Morse]

It does sound like a dup, except this behavior on the mac was occuring first, 
long before the infrastructure changes that caused the cutting to occur on all 
three platforms.  However, it would be fine to dup this since the verification 
testing would make sure it was corrected on all platforms and so would catch the 
case if the mac were still broken at the end.

Comment 11

[John Morrison]

Sorry. I was looking at this for the last while. I have found a distinct bug
in the tab controls that needs to be addressed. However, I think it was being
exacerbated a bit by the use of width: inline style in several places in the 
dialog. In other words, it can be mostly worked around (I believe). 

I'll file a separate bug for the tab controls problem [It appears that the 
width of the text in the <tab>s is not being properly accounted for in 
determining window size and the placement of siblings within the window (e.g., 
the dialog OK/Cancel buttons).

Comment 12

[Stephen P. Morse]

Are you going to check in the work-around?

Comment 13

[John Morrison]

removing the explicit sizes from the 'window.openDialog' and from the 
xul <window> alleviates the 'cut buttons' and still results in a reasonable
(intrinsically) sized dialog on mac/win32/linux. [Actually, this bug never
seemed to affect linux, likely due to different code for the windows].

I hope this diff doesn't get too scrambled, but it's just two one-liners.
Of course, I don't know whether this fix is consistent with other considerations
you have for these dialogs.


jrgm% cvs diff xpfe/global/resources/content/tasksOverlay.js
Index: xpfe/global/resources/content/tasksOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/tasksOverlay.js,v
retrieving revision 1.53
diff -r1.53 tasksOverlay.js
350c350
<       
window.openDialog("chrome://communicator/content/wallet/SignonViewer.xul","SSVie
wer","modal,chrome,height=504,width=436"); 
---
>       
window.openDialog("chrome://communicator/content/wallet/SignonViewer.xul","SSVie
wer","modal,chrome"); 


jrgm% cvs diff extensions/wallet/signonviewer/SignonViewer.xul
Index: extensions/wallet/signonviewer/SignonViewer.xul
===================================================================
RCS file: /cvsroot/mozilla/extensions/wallet/signonviewer/SignonViewer.xul,v
retrieving revision 1.24
diff -r1.24 SignonViewer.xul
33d32
<         width="470" height="440"

p.s. I'll still be looking into this other bug (or what I think I saw) and 
filing it when I know what it is (exactly).

Comment 14

[verah (gone)]

Reassigning as per Don

Comment 15

[sairuh (rarely reading bugmail)]

hokay, i'm dup'ing this. other spinoffs/related-but-not-quite-the-same-issues,
pls file a separate bug. thx! :-)

*** This bug has been marked as a duplicate of 34200 ***

Comment 16

[John Morrison]

This is not a duplicate of bug #34200. (And what's with dup'ing bugs with 
proposed fixes in them, in favour of ones that don't have them).

Comment 17

[Stephen P. Morse]

I agree, this is not a dup of 34200.  This one has to do with buttons, tab 
headings, etc. being truncated whereas 34200 has to do with text insufficient 
width causing text to be wrapped.  (John Morrison said he would open a separate 
bug on the tab-heading problem, but I couldn't find it so I assume that 
currently this bug covers both problems.)

A more dramatic example of the tab-heading problem is found in bug 35664 which 
gives instructions for how to exagerate the problem by changing the font size 
(simulates what would happen when some of the text gets localized into a 
different language).

Comment 18

[Stephen P. Morse]

Ben, recommend you reconsider changing the M18 milestone on this to something 
sooner.

Comment 19

[Stephen P. Morse]

*** Bug 35664 has been marked as a duplicate of this bug. ***

Comment 20

[Stephen P. Morse]

Got it.  Problem was in the call to openDialog that was in the task menu 
(tasksOverlay.js) for the cookie viewer, the signon viewer, and the wallet 
editor.  The calls to these three from the pref panel did not have the problem 
and the dialogs came up fine when called from the pref panel.

The change was as follows:

  Original call for wallet editor (similar for cookie and singon viewer):

    window.openDialog
      ("chrome://communicator/content/wallet/WalletEditor.xul",
      "walletEditor",
      "modal,chrome,height=504,width=436"); 

I changed the last argument above to

      "modal=yes,chrome,resizable=no"

and that fixed the problem.

Comment 21

[sairuh (rarely reading bugmail)]

on today's linux build [opt comm, 2000.05.15.08], the dialog for stored
passwords still has the Cancel button completely clipped off (as well as part of
the OK button). on winNT (same build), the Cancel button is partially clipped.

jrgm/shrir, do you see this too? i'm running enlightenment/gnome (which i think
you're running, unless am mistaken). wonder if i should reopen --unless the fix
for this is blocked by bug 39248 (overlays trounce commercial bits).

Comment 22

[Stephen P. Morse]

Yes, I just discovered it too, before I saw your comment above.  There was a 
problem before that affected cookieviewer/signonviewer/wallet-editor and that's 
what I fixed yesterday.  Now I see another problem that affects just 
signonviewer and I have a fix ready to be checked in just as soon as the tree 
opens.

Comment 23

[Stephen P. Morse]

Fix has been checked in.  Change was in SignonViewer.xul.  Try it again.