If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

no branch parameter no longer means "any branch"

RESOLVED FIXED

Status

Webtools Graveyard
Bonsai
--
critical
RESOLVED FIXED
13 years ago
a year ago

People

(Reporter: myk, Assigned: Tara Hernandez)

Tracking

Details

(Reporter)

Description

13 years ago
Since the fix for bug 237525 was checked in, omitting the branch parameter when
calling cvsquery.cgi no longer makes cvsquery.cgi display checkins for any
branch.  It now displays checkins for the "HEAD" branch (or something like this;
dbaron and cls understand the problem, I'm just making sure we have something on
file).

Comment 1

13 years ago
I want a recount.  Looking at the trunk code again, it still has the check that
makes no omitting the branch act as branch=HEAD.  I did remove this check on my
branch (and added it back later).

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bonsai/cvsquery.cgi&rev=1.42#173

I'm assuming that cvsquery.cgi & cvsquery.pl were both upgraded when this
problem was discovered?

Comment 2

13 years ago
Ok, the bad assumption (that branchtype would be set) has been fixed.  For those
following along at home, the expected(?) behavior is that:

not setting branch searches the HEAD branch (branch = '' in sql)
setting branch to an empty string (branch=) searches all branches
setting the branch to HEAD searches the HEAD branch (branch = '' in sql)
setting the branch to any other value searches that branch

Having the first 2 cases be equivalent seems more intuitive to me but whatever.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.