272608 - bonsai shows   in title

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

<TITLE>Checkins to directory mozilla/toolkit by cbiesinger%web.de since
2004-02-01&amp;nbsp;00:00 :</TITLE>

this & should not be escaped...

Comment 1

[Giacomo Magnini]

Attachment: Just to make it more clear

Comment 2

[Mike Taylor [:bear]]

Attachment: patch to make html_quote ignore  

simple fix to make the   not get quoted - the & quoting was a bit too aggressive

Comment 3

[cls]

Comment on attachment 307331 [details] [diff] [review]
patch to make html_quote ignore  

I think a more in-depth fix is required since we're obviously encoding something twice which isn't guaranteed to work. 

I think the better fix would be to change the date string to not contain the   .  The only reason I can think of to use   is to prevent (or is it to cause?) wrapping.

Comment 4

[Mike Taylor [:bear]]

(In reply to comment #3)
> (From update of attachment 307331 [details] [diff] [review])
> I think a more in-depth fix is required since we're obviously encoding
> something twice which isn't guaranteed to work. 
> 
> I think the better fix would be to change the date string to not contain the
>   .  The only reason I can think of to use   is to prevent (or is it
> to cause?) wrapping.
> 

Yep - it was added to prevent the date range from being wrapped so the two dates are on different lines.

I don't think we are encoding it twice, the bug is that the & in   is being  encoded to & when it shouldn't be and generating a string of  

Comment 5

[Mike Taylor [:bear]]

Attachment: patch to make html_quote ignore  

Comment 6

[cls]

Comment on attachment 308009 [details] [diff] [review]
patch to make html_quote ignore  

What I meant was that maybe we shouldn't be encoding the   in the original date string but I'm not seeing a quick way around that.

rs=cls

Comment 7

[Mike Taylor [:bear]]

patch applied

/cvsroot/mozilla/webtools/bonsai/globals.pl,v  <--  globals.pl
new revision: 1.52; previous revision: 1.51
done