Last Comment Bug 272630 - On 'svg' elements getScreenCTM behaves differently to other implementations
: On 'svg' elements getScreenCTM behaves differently to other implementations
Status: RESOLVED FIXED
SVGWG
: fixed1.8
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: ---
Assigned To: Jonathan Watt [:jwatt]
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-01 12:02 PST by Jonathan Watt [:jwatt]
Modified: 2005-10-03 11:39 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.46 KB, patch)
2005-01-10 04:43 PST, Jonathan Watt [:jwatt]
no flags Details | Diff | Splinter Review
testcase 1 - getScreenCTM on 'svg' (604 bytes, image/svg+xml)
2005-09-28 09:02 PDT, Jonathan Watt [:jwatt]
no flags Details
testcase 2 - getScreenCTM on 'circle' (593 bytes, image/svg+xml)
2005-09-28 09:21 PDT, Jonathan Watt [:jwatt]
no flags Details
testcase 3 - getScreenCTM on 'circle' with a 'translate' attribute (622 bytes, image/svg+xml)
2005-09-28 09:24 PDT, Jonathan Watt [:jwatt]
no flags Details
testcase 4 - getScreenCTM on SVG embedded inline in XHTML (961 bytes, image/svg+xml)
2005-09-28 09:48 PDT, Jonathan Watt [:jwatt]
no flags Details
unfinished snapshot (24.23 KB, patch)
2005-09-28 10:15 PDT, Jonathan Watt [:jwatt]
no flags Details | Diff | Splinter Review
probably finished patch (30.03 KB, patch)
2005-09-28 19:09 PDT, Jonathan Watt [:jwatt]
tor: review+
tor: superreview+
asa: approval1.8b5+
Details | Diff | Splinter Review
testcase 5 - getScreenCTM on 'circle' with currentScale/Translate changed (771 bytes, image/svg+xml)
2005-09-29 08:29 PDT, Jonathan Watt [:jwatt]
no flags Details

Description Jonathan Watt [:jwatt] 2004-12-01 12:02:28 PST
Bug go make sure I follow up on this:
http://lists.w3.org/Archives/Public/www-svg/2004Sep/0066.html
Comment 1 Jonathan Watt [:jwatt] 2005-01-10 04:43:48 PST
Created attachment 170818 [details] [diff] [review]
patch

Okay, this is how I think we should behave, which happens to be the way the
ASV6 alpha behaves (bar a bug I found in it). Certainly we should be accounting
for the transform due to the x and y attributes. I also think we should be
appending the viewBox to viewport transform. There is a note in the source
saying that if we do that for nsSVGSVGElement we need to modify
nsSVGGraphicsElement::GetCTM, but I don't see why. The only time
nsSVGGraphicElement::GetCTM effects nsSVGSVGElement::GetCTM or visa versa is in
nsSVGSVGElement::GetCTM.
Comment 2 Jonathan Watt [:jwatt] 2005-01-10 08:16:12 PST
Comment on attachment 170818 [details] [diff] [review]
patch

cancelling review request since we can't just use x and y (they are ignored on
outer <svg> elements)
Comment 3 Jonathan Watt [:jwatt] 2005-01-11 08:33:12 PST
I've followed up this issue in the thread beginning at
http://lists.w3.org/Archives/Public/www-svg/2005Jan/thread.html#15
Comment 4 Jonathan Watt [:jwatt] 2005-01-24 10:28:45 PST
CC'ing Chris and Dean. I haven't recieved any confirmation from the SVG WG that
this is an issue, or alternatively an explaination of why it isn't an issue. If
it is agreed that there is ambiguity here, can we have some clarification on
what the correct behaviour is please?
Comment 5 Jonathan Watt [:jwatt] 2005-09-28 09:02:09 PDT
Created attachment 197708 [details]
testcase 1 - getScreenCTM on 'svg'
Comment 6 Jonathan Watt [:jwatt] 2005-09-28 09:21:14 PDT
Created attachment 197715 [details]
testcase 2 - getScreenCTM on 'circle'
Comment 7 Jonathan Watt [:jwatt] 2005-09-28 09:24:24 PDT
Created attachment 197718 [details]
testcase 3 - getScreenCTM on 'circle' with a 'translate' attribute
Comment 8 Jonathan Watt [:jwatt] 2005-09-28 09:48:26 PDT
Created attachment 197722 [details]
testcase 4 - getScreenCTM on SVG embedded inline in XHTML
Comment 9 Jonathan Watt [:jwatt] 2005-09-28 10:15:43 PDT
Created attachment 197726 [details] [diff] [review]
unfinished snapshot

The changes to GetScreenCTM are "finished" and pass all the tests I just
attached. GetCTM and GetTransformToElement still need work.
Comment 10 Jonathan Watt [:jwatt] 2005-09-28 19:09:19 PDT
Created attachment 197790 [details] [diff] [review]
probably finished patch

This is as far as I'm going with this tonight. I'm fairly confident this is
correct, but I'll do some more testing tomorrow.
Comment 11 Jonathan Watt [:jwatt] 2005-09-29 08:29:31 PDT
Created attachment 197861 [details]
testcase 5 - getScreenCTM on 'circle' with currentScale/Translate changed
Comment 12 Jonathan Watt [:jwatt] 2005-10-02 17:02:32 PDT
Comment on attachment 197790 [details] [diff] [review]
probably finished patch

Requesting approval. This bug fixes a high visibility conformance issue. The
modified methods are not run by our internal code, they are only used by
content. The risk from this change should be very low.
Comment 13 Asa Dotzler [:asa] 2005-10-03 10:50:24 PDT
Comment on attachment 197790 [details] [diff] [review]
probably finished patch

last day for non-critical changes.

Note You need to log in before you can comment on or make changes to this bug.