27266 - Remove All Styles should work for all text attributes, not just B,I,U

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Charles Manske]

Current implementation of this loops 3 times through RemoveInlineProperty
for B, I, and U. First, this ignores all other inline HTML attributes.
Second, it is inefficient. We should make nsHTMLEditor::RemoveInlineProperty
remove all inline attributes during the same iteration search through nodes
in the selection.

Comment 1

[sujay]

it doesn't even work for B, I, U

Comment 2

[Charles Manske]

Also, using this to turn off all text attributes at a collapsed selection
(caret point) needs work. It currently doesn't work at all. I tried changing
attribute names from 'B', 'I', and 'U' to 'b', 'i', and 'u', and then it acted
strange: Using command in bold text did turn of bold, but it turned on italic
and underline! This needs investigation.

Comment 3

[Charles Manske]

*** Bug 26994 has been marked as a duplicate of this bug. ***

Comment 4

[Charles Manske]

Joe says he was planing on doing this. We need to replace existing JS with
an nsEditor::RemoveInlineAttributes() (or some name like that.)
It should "remove all inline nodes that are also containers" as Joe says,
but it should NOT remove <a>, i.e., links.

Comment 5

[Charles Manske]

Joe: After you implement the nsEditor method, please use it to change
nsEditorShell::RemoveTextProperty() for the case when "prop" = "all".
Or you can reassign this to me and I'll fix up that code.

Comment 6

[rubydoo123]

moving to M16

Comment 7

[rubydoo123]

updating keyword and status whiteboard to reflect that this is a beta 2 feature 
work bug that the Composer team deems a must fix for beta 2.

Comment 8

[Joe Francis]

i accept Bugzilla as my lord and savior.  

Comment 9

[Joe Francis]

fixed

Comment 10

[sujay]

verified in 4/26 build.