272662 - configure check fails if JAVA_HOME has a space in it

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Darin Fisher]

configure check fails if JAVA_HOME has a space in it, e.g.:

  $ export JAVA_HOME="/cygdrive/c/Program Files/jdk1.5.0"

I fixed this by adding double-quotes in a few places.  I also added a call to
"cygpath -w" to ensure that JAVA_INCLUDE_PATH is given as a windows path and not
a cygwin path.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

this patch actually seems to cause problems

Comment 3

[Darin Fisher]

Attachment: v1.1 patch

ok, this works.

Comment 4

[Darin Fisher]

this isn't even sufficient.  JAVA_INCLUDE_PATH has spaces in it still, and "cl"
doesn't like those spaces.

feel free to WONTFIX this bug if you like.  i'm happy to just replace 'Program
Files' with 'progra~1' to get by.

Comment 5

[Benjamin Smedberg]

Attachment: My version

This uses the "-s" option of cygpath to convert JAVA_HOME to a short path before using it. This gets through configure properly, I haven't built it yet but it looks like it will work.

Comment 6

[jhp (no longer active)]

Comment on attachment 202536 [details] [diff] [review]
My version

Sweet!  It builds for me.  Thanks for helping me out.

Comment 7

[Benjamin Smedberg]

Fixed on trunk.

Comment 8

[Benjamin Smedberg]

I'd like this for post-ffox1.5 so we can do xulrunner 1.8 with javaxpcom support, but I don't see an appropriate approval flag.

Comment 9

[[e-mail]]

What about people trying to build using MSYS?

Comment 10

[Benjamin Smedberg]

Neil, I don't know anything about msys, but I'd be happy to accept a patch.

Comment 11

[jhp (no longer active)]

(In reply to comment #8)
> I'd like this for post-ffox1.5 so we can do xulrunner 1.8 with javaxpcom
> support, but I don't see an appropriate approval flag.

Copying the XForms guys, I'll just add "javaconnect-to-branch" to the status whiteboard for all bugs that need to be checked to branch after FF1.5 ships.

Comment 12

[[e-mail]]

Attachment: MSYS fix

Steps to verify patch:
1. Use linux, to avoid the block completely
2. export JAVA_HOME=~/JAVA\ HOME
3. mkdir "$JAVA_HOME"; mkdir "$JAVA_HOME/include"; mkdir "$JAVA_HOME/bin"
4. touch "$JAVA_HOME/include/jni.h"
5. touch "$JAVA_HOME/bin/javac"; touch "$JAVA_HOME/bin/jar"
6. ./configure --enable-extensions=java

Comment 13

[Benjamin Smedberg]

Comment on attachment 202877 [details] [diff] [review]
MSYS fix

I don't get it... I had to add this code to get cygwin to work because cygwin doesn't automatically convert JAVA_HOME from a win-style path to a unix-style path.

Comment 14

[[e-mail]]

Attachment: v1.1 fix

Sorry, I didn't realize that JAVA_HOME was the wrong sort of path.

Note that other parts of configure (should) use FOO=`cd "$BAR" && pwd`

Comment 15

[Benjamin Smedberg]

Comment on attachment 202536 [details] [diff] [review]
My version

With Neil's mingw fix also.

Comment 16

[Mike Schroepfer]

Comment on attachment 202536 [details] [diff] [review]
My version

Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.

Comment 17

[Benjamin Smedberg]

Comment on attachment 202536 [details] [diff] [review]
My version

Re-requesting approval per drivers email, this is javaxpcom-only and has baked on trunk (with the mingw fix).

Comment 18

[Benjamin Smedberg]

Comment on attachment 202536 [details] [diff] [review]
My version

a=drivers

Comment 19

[Benjamin Smedberg]

Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.