Closed
Bug 272677
Opened 20 years ago
Closed 20 years ago
Implement <xforms:secret>
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
Attachments
(1 file)
|
10.34 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
Implement <xforms:secret> Like <textarea>, we can implement this by extending nsXFormsInputElement.cpp ever so slightly.
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta
|
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #167605 -
Flags: review?(bryner)
patch looks good to me. Looking at the patch triggered something else in my head, though. I noticed that if we are handling an input field bound to a node of boolean type, that during Refresh() we treat it as a checkbox and determine whether the value is "true" or "1" and if either, we'll check it, otherwise we won't. Fine. But during "::Blur", we will set the value to 1 or 0 based on whether it is checked or not. So with nothing more than a focus change happening, the instance value could go from "true" to "1". I don't know if that is a desired behavior. What do you think, am I nitpicking? Or should I write a testcase and open a bug?
|
|
Assignee | |
Comment 3•20 years ago
|
||
aaron: i'm not sure either. perhaps it would be good to file a bug about investigating that to see if it is a problem (no need to do the investigation before filing the bug ;-)
|
||
Updated•20 years ago
|
Attachment #167605 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•