272686 - "Sort by name" adds a phantom separator

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[husky]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

When using the "Sort by Name" function to sort bookmarks, the bookmark menu
immediately closes.  Upon opening it again, the bookmarks are properly sorted,
but there is a separator at the bottom of the bookmarks.  Going to the "Manage
Bookmarks" feature allows you to add and delete other separators as usual, but
this new "phantom" separator does not appear in the Manage Bookmarks feature and
thus cannot be deleted.  Closing and reopening Firefox appears to solve this
problem.

Reproducible: Always
Steps to Reproduce:
1. Open the "Bookmarks" menu and right-click on any bookmark.
2. Select "Sort by Name."
3. Open the "Bookmarks" menu again.
Actual Results:  
There is an extra separator at either the bottom or the top of the "Bookmarks"
menu.  This separator does not appear in the "Manage Bookmarks" feature.  This
process can be repeated and will spawn a new separator each time.  After sorting
all my bookmarks' sub-folders, I had one on the bottom and about six on the top.

Expected Results:  
There should be no such separator or separators spawned upon execution of the
"Sort by Name" feature.

The separators can be dispelled by closing and reopening Firefox.  I have yet to
find a way to remove them in the program as "Manage Bookmarks" does not see
them, but closing and reopening Firefox should remove all of them.

Comment 1

[Rotem Liss]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041115 Firefox/1.0

It also happens to me. And also "Boomarks Toolbar Folder" is hidden after I sort.

I sorted in another folder, so it is not only in the main folder.

Can anyone change the summary to the "Bookmarks Toolbar Folder" to include the
hiding of "Bookmarks Toolbar Folder"? (I don't know who has a permision to do
it, I haven't...) And I think it is a minor bug, because of it is solved after
restarting.

Comment 2

[Rotem Liss]

Update: When I sorted it by name the second time, it added a seperator in the
top of bookmarks list. No change in the Bookmarks Manager.

Comment 3

[Brian Kell]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513
Fedora/1.0.4-1.3.1 Firefox/1.0.4

Me too. Firefox 1.0.4 on Fedora Core 3.

Extensions installed, just in case: Add Bookmark Here 0.5.3, Duplicate Tab
0.5.1, FLST 0.8.1, Mouse Gestures 1.0, Magpie 3.1.2, undoclosetab 20041125.5,
miniT (drag+indicator) 0.5, Open link in... 1.3

Comment 4

[Brian Kell]

It also seems to hide the first folder in the Bookmarks menu.

Comment 5

[Tim Gokcen]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

Firefox 1.0.5 also does this in Fedora Core 1 (gnome 2.4.0). I gain an extra
separator at the bottom and the first subfolder in my Bookmarks folder
disappears until I restart FF.

The only extensions I have installed are AdBlock and AddBookmarkHere. I am using
the "Phoenity" theme (with no other themes installed save the base).

Comment 6

[Tim Gokcen]

Guess what. Disabling "Add Bookmark Here" eliminates the problem :/
We should contact the author of that extension.

http://gorgias.de/mfe/

Comment 7

[Rotem Liss]

(In reply to comment #6)
> Guess what. Disabling "Add Bookmark Here" eliminates the problem :/
> We should contact the author of that extension.
> 
> http://gorgias.de/mfe/

The extension was installed on my Firefox when I reported about it, so it may
being right. Suggesting Resolved Invalid, if it will be proved.

Comment 8

[Daniel Lindkvist]

I'm the creator of "Add bookmark here" and I know about this problem.
Unfortunately I haven't yet found the code responsible for bookmarks sorting so
I have a hard time debugging this. My guess is that the sorting code don't check
for other items besides "Open in tabs" Maybe that should be changed instead of
the extension to make it easier for extension authors to add things to the
bookmarks menu?

Any help fixing this would be much appreciated!

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 10

[Aaron Racine]

I was able to reproduce this with the "Add bookmark here" extension.  I was NOT able to reproduce this without that extension.

Daniel, if you have a suggestion on how to improve firefox to make it easier for extension authors to do something, you should probably file it as a separate feature request.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/2007051502 Firefox/2.0.0.4

Comment 11

[Samuel Sidler (old account; do not CC)]

Resolving INVALID since this is a problem that's caused by an extension. Daniel, please file an RFE on improvements to the bookmarks menu if you have specific requests. Be sure to participate in the Places work being done on trunk since that could have a substantial effect on any bookmarks-related extensions and UI.