272705 - Error ``document.getElementById("cmd_SwitchTextDirection") has no properties'' [xs] in file ``chrome://communicator/content/utilityOverlay.js'', line 387, character 0.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[timeless]

Error ``document.getElementById("cmd_SwitchTextDirection") has no properties''
[xs] in file ``chrome://communicator/content/utilityOverlay.js'', line 387,
character 0.
Stopped for error handler.
#0: function goUpdateGlobalEditMenuItems() in
<chrome://communicator/content/utilityOverlay.js> line 387
385: try {
386: // XXX: implement controller for cmd_SwitchTextDirection
387: document.getElementById('cmd_SwitchTextDirection').setAttribute('disabled',
388: !document.commandDispatcher.focusedElement);
389: }

This happens in various windows including venkman, it's amazingly annoying.

Comment 1

[timeless]

Attachment: look before we leap

Comment 2

[Asaf Romano (gone)]

err, my bad :-/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Isn't that why the code is in a try/catch block?

Comment 4

[[e-mail]]

bz: if you set Venkman to break or trace on exception (as opposed to break or
trace on error) then you'll see exceptions before they get caught.

The hack could consider removing the try/catch block too.

The correct fix is for Mano to write the cmd_SwitchTextDirection controller :-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

The break-on-exception mode is already painful enough, since so much of the
XPCOM traffic _does_ throw exceptions for normal things (security checks, anyone?)

Comment 6

[Asaf Romano (gone)]

timeless, i guess you want to remove the try block if you're landing this one.

Comment 7

[timeless]

can't document.commandDispatcher.focusedElement fail? :)

Comment 8

[[e-mail]]

Comment on attachment 167612 [details] [diff] [review]
look before we leap

r+sr=me if you remind Mano to fix it properly ;-)

If focusedElement fails we're in real trouble :-P