272798 - Theme manager has problems with pngs.

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Tyler Bannister]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Using FireFox 1.0 with the "Install New Theme 0.3" extension, I was working on a
custom theme.  When I replaced the icon.png (an only the icon.png) in an working
theme.jar, it caused the theme to fail to install properly.  This behaviour
seems to happen with transparent pngs and pngs with a dpi of 96 and a comment
(the output from Photoshop 7.0).

Opening the icon.png file in the GIMP 2.0 and re-saving as a png without any
modifications and replacing the icon.png in the theme.jar with the new version 
caused the theme to install properly with the new icon.  The GIMP reset the dpi
to 72 and stripped the comment.

When I try to install the theme.jar with the Photoshop or transparent icon.png
the theme either briefly appears on the theme list and then disappears, or it is
listed with what appears to be a default theme icon, no information and a no
preview.png file message in the preview window.

Reproducible: Always
Steps to Reproduce:
1. Install the "Install New Theme 0.3" extension so you can install local themes.
2. Create a PNG with Photoshop 7.0 or a transparent png.
3. Replace the icon.png in any theme jar file with the new png.
4. Install the theme

Actual Results:  
The theme failed to install correctly, either disappearing from the window or
failing to display any of the informations specified in the contents.rdf file(s).

Expected Results:  
Installed the theme with new icon displayed.

I have 4 cash ids that may be related to this problem or potentially to errors
in my rdf.  They occured while I was trying to get my theme to work:
TB2296016Q, TB2293665H, TB2293338W, TB2292697W

Comment 1

[Tyler Bannister]

Attachment: A sample "bad" png

This is a PNG that has a gamma channel, if you replace the icon.png in a theme
package with it, the theme will no longer install correctly.

Comment 2

[Nickolay_Ponomarev]

Seems to work for me. I took Pinball 0.9.9.1, replaced icon.png inside with
saved icon.png (5548 bytes) and it installed ok. Are you sure you attached
correct image? Can you load the "bad" image in Firefox by typing its URL in
location bar?

I drag and dropped the jar file instead of using the extension.

Comment 3

[Tyler Bannister]

Attachment: Ok, this one is actually bad.

D'oh, wrong file.

Comment 4

[Tyler Bannister]

Testing on my home computer (Windows 2000 with Firefox 1.0) gives me slightly
different behaviour with Qute and the second PNG.  Qute installs on every second
try.  The first time it briefly shows up and then disappears, the second time it
doesn't disappear (Drag'n'Drop or via "Install New Theme 0.4").  Also trying
Noia 2.0 with a transparent PNG and got the same behaviour.

Comment 5

[Nickolay_Ponomarev]

Couldn't reproduce with Pinball. The file is 917 bytes long now.

Comment 6

[Robert Strong (they/them - no direct email)]

This was probably due to the zip reader cache holding the jar file open when
installing the theme and thereby preventing the install. The icon and preview
images were read directly from the jar file and I have reproduced this bug
previously. Since the patch for bug 291946 landed I have not been able to
reproduce this behavior and I was unable to reproduce this behavior with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050604
Firefox/1.0+ ID:2005060409

Also of note is bug 295013 which fixes a similar issue.

Tyler - can you verify this is fixed with a current nightly?

Comment 7

[Robert Strong (they/them - no direct email)]

I am very sure this is now WFM after the patches for the bugs I mentioned landed.