272814 - beginAddingChildren notification should be called before attributeSet.

Status: RESOLVED FIXED

(Core Graveyard :: XTF, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041126
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041126

I think beginAddingChildren notification should be called before the first
attributeSet. This way it is easier to support dynamic DOM modifications.
Patch coming.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: fix

Comment 2

[Darin Fisher]

but an attribute is not really a child of an element is it?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

no, it is not, but this is just about ordering of the notifications.
we could also add again one new notification, called startParsingContent or 
something, or rename beginAddingChildren, or even more, add two notifications
beginAddingAttributes, doneAddingAttributes. But I don't think those
are really needed.

Comment 4

[Darin Fisher]

Comment on attachment 167660 [details] [diff] [review]
fix

makes sense to me.  r=darin 

but, can you please add documentation to nsIXTFElement explaining the
relationship of this event to the other events?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: adding a comment to nsIXTFElement

Comment 6

[Darin Fisher]

fixed-on-trunk