272874 - Error: nsresult: "0x804b000a (<unknown>)" location: "JS frame :: mozilla/components/venkman-service.js :: jsdph_newuri :: line 249" data: no]

Status: RESOLVED INCOMPLETE

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[timeless]

steps:
1. load venkman
2. in the commandline area, enter: "/help"

actual results:
Error: [Exception... "Component returned failure code: 0x804b000a [nsIURI.spec]"
 nsresult: "0x804b000a (<unknown>)"  location: "JS frame ::
file:///C:/Documents%20and%20Settings/timeless/Desktop/mozilla/components/venkman-service.js
:: jsdph_newuri :: line 249"  data: no]
Source File:
file:///C:/Documents%20and%20Settings/timeless/Desktop/mozilla/components/venkman-service.js
Line: 249

many times in the js console.

expected results:
no error :)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

note that 0x804b000a is NS_ERROR_MALFORMED_URI

Comment 2

[James Ross]

Cool. I don't think my JavaScript Console appreciated that at all.

Comment 3

[James Ross]

Well, it appears to occur once for each x-jsd: link on the page, and again each
time you hover/leave such a link. I'd really like to know what |spec| is.

Comment 4

[James Ross]

Whoops, not quite right. It's for the <a href="#top">Back To Top</a> links.

Comment 5

[James Ross]

Looks like nsSimpleURI requires spec to have a : in it (seems fairly sensible),
which is where this is (probably) failing. Maybe change
http://lxr.mozilla.org/mozilla/source/extensions/venkman/js/venkman-service.js#244
in a similar vein to
http://lxr.mozilla.org/mozilla/source/extensions/venkman/js/venkman-service.js#218 ?

I don't know if that's what's going on, but I would have expected (meaning what
doesn't happen) it to /resolve/ the URI against the page's URI first. biesi?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

what's baseURI.spec at jsdph_newuri? newURI is supposed to resolve the string
relative to that baseURI, but if that protocol does not support relative uris,
throwing malformed_uri like this does is ok.

how does your proposed change handle a link of say, "foo"? (also a relative link...)

sounds to me like the caller should deal ;)

what does /help do exactly?

Comment 7

[James Ross]

I believe baseURI.spec is "x-jsd:help". Note that as I understand it the URI
"foo" is not a valid relative URI within the protocol x-jsd. In fact, as
http://lxr.mozilla.org/mozilla/source/extensions/venkman/js/venkman-service.js#233
says, x-jsd doesn't do relative URIs at all.

As for resolving, look at jsduri_resolve - surely that is exactly the code it
should be using to resolve it (as suggested) in jsdph_newuri?

/help loads the page "x-jsd:help" into the browser, which is a dynamically
generated page based on Venkman's loaded help texts and commands. It includes
both links like <a href="x-jsd:help?search=break">break</a> and the #top one
already mentioned.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, ok. in that case, sounds like newURI should use baseURI.resolve, at least if
its scheme is x-jsd.

Comment 9

[BMO Automation]

Component is obsolete so resolving bugs as INCOMPLETE