Closed Bug 272876 Opened 20 years ago Closed 16 years ago

Inefficient code in updateAttribute function of the bookmark properties window

Categories

(Firefox :: Bookmarks & History, defect, P5)

2.0 Branch
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

If statements are redundant. Patch to follow.

Reproducible: Always
Steps to Reproduce:
1. Take a look at the code at
http://lxr.mozilla.org/aviarybranch/source/browser/components/bookmarks/content/bookmarksProperties.js#348
Attached patch PatchSplinter Review
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
Attachment #167697 - Flags: review?(vladimir)
Assignee: vladimir+bm → nobody
Assignee: nobody → jeffrey.bugzilla
Priority: -- → P5
QA Contact: mconnor → bookmarks
Target Milestone: --- → Firefox1.6-
Status: NEW → ASSIGNED
Comment on attachment 167697 [details] [diff] [review]
Patch

Clearing old bugs from review queue (Places taking over here)
Attachment #167697 - Flags: review?(vladimir)
Version: Trunk → 2.0 Branch
Target Milestone: Firefox 2 → ---
not going to take further fixes on 2.x, feel free to reopen if you can reproduce on 3.x or current trunk
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: