27289 - Right clicking on any part of scrollbar shows context menu

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Seth Nickell]

Right clicking on the scrollbar displays the last context menu.

Two simple examples:

Load mozilla, open a web page. Before using any context menus right click on the
scrollbar. It (presumably) lists every context menu the browser knows about.

Then try right clicking on a link. Now right click on the scrollbar to find that
the menu is the same as on the link (with options like "Open in New Window".

Should the scrollbar even *have* a context menu?

Comment 1

[Mike Pinkerton (not reading bugmail)]

probably a job for don's team, to ensure that the target is not a scrollbar.

Comment 2

[Asa Dotzler [:asa]]

*** Bug 27209 has been marked as a duplicate of this bug. ***

Comment 3

[Paul MacQuiddy]

*** Bug 28046 has been marked as a duplicate of this bug. ***

Comment 4

[Peter Trudelle]

*** Bug 28529 has been marked as a duplicate of this bug. ***

Comment 5

[Matthew T (active 1999-2002)]

Reproduced on MacOS build 2000032308, MacOS 8.6. Platform & OS == All.

Comment 6

[John Morrison]

*** Bug 34841 has been marked as a duplicate of this bug. ***

Comment 7

[Seth Nickell]

Problem still remains....

Comment 8

[Seth Nickell]

...and its fixed... =)

Comment 9

[sairuh (rarely reading bugmail)]

still see this: 2000.05.09.08 commercial bits. reopening --do let me know if
this is not an issue with mozilla bits, tho'.

Comment 10

[verah (gone)]

Reassigning as per Don

Comment 11

[don]

Move to M20 target milestone.

Comment 12

[don]

Oops.  Should be M21.

Comment 13

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 14

[R.K.Aa.]

*** Bug 45837 has been marked as a duplicate of this bug. ***

Comment 15

[Matthew T (active 1999-2002)]

*** Bug 46441 has been marked as a duplicate of this bug. ***

Comment 16

[Blake Ross]

Someone (I forget who, and can't find the bug right now) fixed this while 
fixing another bug.  The only remaining problem now is that right clicking on 
the scrollbar thumb will show a context menu.  This should be no harder then 
adding another check to see if the source is a thumb node, so when I get a 
chance, I'll take a look.

Comment 17

[Blake Ross]

reassigning to me to investigate

Comment 18

[Blake Ross]

Attachment: patch - why is |this.target.parentNode.tagName| returning |xul:slider| and not |slider|?

Comment 19

[Blake Ross]

attached a patch - please review.

Comment 20

[Bill Law]

r=law

Nice work, Blake.

This broke after I originally fixed it because of some subtle change with 
respect to anonymous children of xbl widgets.  I heard Dave Hyatt talking about 
it but the bug never came to my attention (since it ain't [nsbeta3+]).  Thanks 
for backing me up on this one.

Comment 21

[Blake Ross]

no problem. thanks for reviewing.  brendan, could you approve?

Comment 22

[Brendan Eich [:brendan]]

a=[e-mail].

Blake, did you ask a XUL guru (waterson might know) why tagName came back with
the namespace-prefixed "xul:slider"?

/be

Comment 23

[Blake Ross]

Nope.  Waterson, do you have any idea why?

Comment 24

[John Morrison]

Partial answer/guess: this element is coming from the XBL anon content, where it
is declared with the xul: prefix inside the XBL document that defines the binding.

Comment 25

[Blake Ross]

John: probably right.

fix checked in

Comment 26

[R.K.Aa.]

Why is this marked fixed?
WHen i right-click on thumb i still get a context menu.
In addition i get error messages - heaps: One single right-click now spawns this:

Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:slider', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:slider', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:spring', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:thumb', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:slider', is this OK?
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:slider', is this OK?

Comment 27

[R.K.Aa.]

forgot: m18 linux build ID 2000082608

Comment 28

[Blake Ross]

I don't understand what's going on.  I checked in four patches yesterday and 
none of them seem to have taken any effect in today's build.  I am looking into 
it.

Comment 29

[R.K.Aa.]

2000082708

discovered something:
The context menu that now displays when right-clicking scrollbar slider isn't
like it used to be: It used to be either one insanely long one (all possible
items) - or a copy of whatever context-menu had previously been displayed)

Now - instead - it's always one and the same, and it's identical to the one that
should display when one right-clicks somewhere in a normal web-page. (on
content-less area)

Also: RIght-clicking scrollbar thumbs (w/arrows) or on the sliderbar as such
(outside slider) has no effect.


So the behaviour has changed, compared to the original bug.
But that scrollbar slider for some reason thinks it's an extention of a webpage..

Comment 30

[Jerry Baker]

I hope someday that Mozilla can get Win2k's feature of a scrollbar specific
context menu when right-clicking a scroll area (not on the thumb). It's gonna be
hard to play keep-up with native widgets.

Comment 31

[Jerry Baker]

Sorry for the spam. Adding self to CC.

Comment 32

[R.K.Aa.]

[e-mail]: the feature you talk about is already filed as
enhancements bugs: bug 38466 and bug 38467 (both "future")

Comment 33

[R.K.Aa.]

2000082916 m18 linux

Menu still there.. and..
clicking right mousebutton down on slider area spawns 7 lines like this:
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:slider', is this OK?

clicking right mousebutton down on scrollbar's arrow widgets spawn 7 of these:
Possible DOM Error: .name, .nodeName or .tagName requested on a namespace
element/attribute with the qulaified name 'xul:scrollbarbutton', is this OK?

Reopening.

Comment 34

[Chris Veenboer]

I don't know if this is related,
When I drag the scrollbar, then right-click, I get a pop-up menu,
and (this only happens somtimes) the menu stays active, I can release both
mousebuttons. My mouse now moves normally, I can use the context menu, and the
scrollbar still reacts as if I'm holding down the left button.

(build 2000080712)

Comment 35

[R.K.Aa.]

2000090206 linux:
error messages gone. Menu remains.

Comment 36

[R.K.Aa.]

Linux 2000-090708: no menu anymore?!
(is this too good to last..)

Comment 37

[Blake Ross]

I don't know.  Let's take advantage of it and re-mark it FIXED while it still 
works!

Comment 38

[R.K.Aa.]

It's back :/

Comment 39

[Blake Ross]

I have a sneaking suspicion that this regression is due to bug 53537 (about 
event.target.localName returning "HTML")

Comment 40

[John Morrison]

Possibly. That other bug I have a fix for, and it is simply to use 
event.originalTarget when dealing with the scrollbar. Otherwise, you
get the parent document when dealing with anonymous content (or words
to that effect).

Comment 41

[Blake Ross]

reopening because context menus are now shown when you right click on *any* 
part of the scrollbar (slider, arrows, and background).  what syntax changed?

Comment 42

[Fabian Guisset]

This still happens:
Right-clicking on the scrollbar pops-up the exact same context menu as when
clicking in the content part of the window.
Maybe this simply will be fixed when XBL events bubble last? (I heard that's
what's supposed to happen anyway). Approval and patch keywords should be
removed, imho.

Comment 43

[Blake Ross]

I think pink is planning on preventing this at a higher level than xpapps 
(along with other stuff, like certain form controls).  cc'ing him

Comment 44

[Mike Pinkerton (not reading bugmail)]

i just checked in a fix for this.

Comment 45

[Mike Pinkerton (not reading bugmail)]

.

Comment 46

[Blake Ross]

I still get a context menu on Windows.

Comment 47

[Mike Pinkerton (not reading bugmail)]

what skin?

Comment 48

[Mike Pinkerton (not reading bugmail)]

ah, it's win32 classic. i guess they don't use the same scrollbar bindings as the 
others. --> skins.

Comment 49

[Blake Ross]

Attachment: [patch] I can't believe this wasn't done earlier

Comment 50

[Blake Ross]

hewitt, sr?

Comment 51

[Joe Hewitt (gone)]

yikes. sr=hewitt

Comment 52

[Jason Kersey]

r=kerz

Comment 53

[Blake Ross]

Fix was checked in.

Comment 54

[Patty Mac]

Verified the patch.

Comment 55

[Jerry Baker]

Mass removing self from CC list.

Comment 56

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.