Implement nsChildView::CancelIMEComposition()

RESOLVED FIXED in Camino0.9

Status

Camino Graveyard
General
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: masayuki, Assigned: Mike Pinkerton (not reading bugmail))

Tracking

({intl})

unspecified
Camino0.9
PowerPC
Mac OS X

Details

(URL)

Attachments

(1 attachment)

1.01 KB, patch
Mike Pinkerton (not reading bugmail)
: review+
Josh Aas
: review+
Brian Ryner (not reading)
: superreview+
Details | Diff | Splinter Review
Implement |nsChildView::CancelIMEComposition|.
This is related bug 163572.

waverider will attach the patch.

Comment 1

13 years ago
Created attachment 167737 [details] [diff] [review]
Implement nsChildView::CancelIMEComposition()

note:
When CancelIMEComposition() called,
mView and current Input Manager should flush markedText.

InputManager abandone markedText by "markedTextAbandoned:",
"unmarkText" flush markedText.
InputManager received "unmarkText" send "unmarkText" to mView,
Flushing markedText is completed.
(Reporter)

Updated

13 years ago
Attachment #167737 - Flags: review?(pinkerton)
(Assignee)

Comment 2

13 years ago
Comment on attachment 167737 [details] [diff] [review]
Implement nsChildView::CancelIMEComposition()

r=pink
Attachment #167737 - Flags: review?(pinkerton) → review+
(Reporter)

Updated

13 years ago
Attachment #167737 - Flags: superreview?(bryner)
(Assignee)

Comment 3

13 years ago
josh can you take a gander at this? we don't need bryner to sr in cocoa widget. 
(Assignee)

Updated

13 years ago
Target Milestone: --- → Camino0.9

Comment 4

13 years ago
Comment on attachment 167737 [details] [diff] [review]
Implement nsChildView::CancelIMEComposition()

Looks fine to me, but I haven't actually tested it. Assuming this works I have
no gripes with the code.
Attachment #167737 - Flags: review+

Comment 5

13 years ago
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Attachment #167737 - Flags: superreview?(bryner) → superreview+
You need to log in before you can comment on or make changes to this bug.