272974 - nice scriptable wrappers for storage

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attached patch implements some nice scriptable wrappers for storage, allowing
for stuff like:

 var stmt = dbconn.createStatement(sql);
 var wrapper =
Components.classes["@mozilla.org/storage/statement-wrapper;1"].createInstance(Components.interfaces.mozIStorageStatementWrapper);
 wrapper.initialize(stmt)

 wrapper(1, 2, 3);   // call wrapper function with 1,2,3 args
 while (wrapper.step()) {
   dump(wrapper.row.columnA);
   dump(wrapper.row.columnB);
 }

 wrapper.params[0] = 1;
 wrapper.params[1] = 2;
 while (wrapper.step()) {
   ...
 }

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 272974-scriptable-storage-0.patch

Note that this patch will allow us to split out this wrapper from the rest of
storage, ensuring that the core storage interface has no dependency on
js/xpconnect.  Some file reorg will need to happen for that, so punting on that
until later.

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 167740 [details] [diff] [review]
272974-scriptable-storage-0.patch

r=shaver with fixes to f2f-review comments.

Comment 3

[Darin Fisher]

quick comment: snprintf should be PR_snprintf for portability.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #3)
> quick comment: snprintf should be PR_snprintf for portability.

or PR_smprintf, then you don't need to do that length calculation yourself