273089 - Add scriptable getters to nsXULAppAPI information.

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Benjamin Smedberg]

This will in the future allow the extension manager to pick up the app UUID and
other information from a scriptable interface, instead of using prefs.

Comment 1

[Benjamin Smedberg]

Attachment: Scriptable nsXULAppAPI

Comment 2

[Darin Fisher]

Comment on attachment 167807 [details] [diff] [review]
Scriptable nsXULAppAPI

>Index: nsAppRunner.cpp

>+NS_IMETHODIMP
>+nsXULAppInfo::GetVendor(nsACString& aResult)
>+{
>+  if (gAppData->appVendor)
>+    aResult.Assign(gAppData->appVendor);
>+  else
>+    aResult.Truncate();
>+
>+  return NS_OK;
>+}

how about this instead:

  aResult.Assign(gAppData->appVendor ? gAppData->appVendor : "");

I'd probably null check the rest just like this.  I know that
some of the fields are required (and LoadAppInfo happens to make
that a requirement), but we don't yet do similar checking for
aAppInfo, and we don't document the required fields in nsXULAppAPI.h



>Index: nsIXULAppInfo.idl

maybe add a comment that this interface is not finished, may
change with the addition of new fields, etc.

Comment 3

[Benjamin Smedberg]

Fixed on trunk. I added null-checks to everything except the "name" parameter,
since if that's null we crash much earlier.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

+ * The contract id for the nsIXULAppInfo service.
+ */
+#define XULAPPINFO_SERVICE_CONTRACTID \
+  "@mozilla.org/xre/app-info;1"

can you also document what interfaces this implements and whether it is supposed
to be used as a service or via createInstance?