Closed
Bug 273149
Opened 20 years ago
Closed 17 years ago
toggling the Match case checkbox does not change the highlighting
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
VERIFIED
FIXED
mozilla1.9beta3
People
(Reporter: tracy, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 2 obsolete files)
1.18 KB,
patch
|
ehsan.akhgari
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
brought over from bug 264842 -in this bug, ctrl+F -preform a search on "Test" with Highlight on and Match Case off. -toggle Match Case on tested results: no change; test and Test are highlighted expected results: Dynamic change to case sensitive of highlighted items; only Test is highlighted. currently you have to toggle highlight off then back on again for the Match case change to take affect on highlighted items
Updated•20 years ago
|
Assignee: p_ch → firefox
Component: Search → Find Toolbar / FastFind
QA Contact: firefox.search
Comment 1•19 years ago
|
||
found the same bug 05/20/05 using 1.04 on Windows 2000
Comment 2•19 years ago
|
||
I can reproduce in Trunk/Linux. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051029 Firefox/1.6a1
OS: Windows XP → All
The Mac version reproduces. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.9a1) Gecko/20051020 Firefox/1.6a1
Hardware: PC → All
Comment 5•19 years ago
|
||
*** Bug 315571 has been marked as a duplicate of this bug. ***
Comment 6•18 years ago
|
||
Per bug 340849 comment 16, this is now INVALID.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
Comment 8•18 years ago
|
||
"Match case" button appeared again by bug 345786. This problem still exists. I am reopening.
Status: VERIFIED → REOPENED
Resolution: INVALID → ---
Reproduced in Firefox 2 (2006082115) on Intel Mac OSX. Toggling the Match case checkbox does not change the highlighting.
Comment 10•18 years ago
|
||
*** Bug 352849 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
QA Contact: fast.find
Assignee | ||
Comment 12•17 years ago
|
||
I can confirm that this problem is present on the current trunk. The fix should be trivial: just call _setHighlightTimeout() in the findbar widget upon sensing a change in the observer for the accessibility.typeaheadfind.casesensitive pref.
Assignee: masayuki → ehsan.akhgari
Status: REOPENED → NEW
Assignee | ||
Comment 13•17 years ago
|
||
This belongs in the toolkit...
Status: NEW → ASSIGNED
Component: Find Toolbar / FastFind → XUL Widgets
Product: Firefox → Toolkit
Target Milestone: --- → mozilla1.9beta1
Assignee | ||
Comment 14•17 years ago
|
||
A simple patch which essentially does the same as when the user changes the text to find in the find bar. The document's highlighting will be refreshed in 500ms.
Attachment #272775 -
Flags: review?(mano)
Updated•17 years ago
|
QA Contact: fast.find → xul.widgets
Comment 15•17 years ago
|
||
Comment on attachment 272775 [details] [diff] [review] Patch to update highlighting upon case-sensitivity pref change The interaction here is kinda odd when having multiple browser windows with a findbar opened (toggling match-case in one window would change highlighting in another).
Attachment #272775 -
Flags: review?(mano) → review-
Assignee | ||
Comment 16•17 years ago
|
||
Revised to address the issue in comment 15.
Attachment #272775 -
Attachment is obsolete: true
Attachment #273544 -
Flags: review?(mano)
Assignee | ||
Comment 17•17 years ago
|
||
mano, do you think you can review attachment 273544 [details] [diff] [review]? It's been waiting for a review for more than two months... Thanks!
Comment 18•17 years ago
|
||
Comment on attachment 273544 [details] [diff] [review] Patch to update highlighting upon case-sensitivity pref change (revised) OK, I guess... it's kinda odd that toggling case-sensitive applies to all windows, but that's out of the scope of this bug. r=mano.
Attachment #273544 -
Flags: review?(mano) → review+
Assignee | ||
Comment 19•17 years ago
|
||
Thanks for the review, Mano.
Target Milestone: mozilla1.9 M8 → mozilla1.9 M11
Assignee | ||
Comment 20•17 years ago
|
||
Unbitrotted patch seeking approval to land.
Attachment #273544 -
Attachment is obsolete: true
Attachment #293558 -
Flags: review+
Attachment #293558 -
Flags: approval1.9?
Comment 21•17 years ago
|
||
Comment on attachment 293558 [details] [diff] [review] Patch to update highlighting upon case-sensitivity pref change (unbitrotted) a=beltzner for drivers
Attachment #293558 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 22•17 years ago
|
||
Checking in toolkit/content/widgets/findbar.xml; /cvsroot/mozilla/toolkit/content/widgets/findbar.xml,v <-- findbar.xml new revision: 1.19; previous revision: 1.18 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Reporter | ||
Comment 23•17 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121805 Minefield/3.0b3pre and the equivalent Mac nightly build. half a second after the match case is toggled, the case sensitivity of high lighted items is changed appropriately.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•