273252 - Description in timezone preferences not able to localize

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Bartosz Piec]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.7.5) Gecko/20041108 Firefox/1.0

Description text in timezone preferences is hardcoded into timezonePrefs.xul as
"This doesn't yet do anything.".

Reproducible: Always
Steps to Reproduce:
1. Start Calendar
2. Select Edit -> Preferences -> Timezone

Actual Results:  
You will see the text: "This doesn't yet do anything." - it is hardcoded.

Expected Results:  
Some description text taken from locales.

To correct this just change this line in timezonePrefs.xul:

	<description>This doesn't yet do anything.</description>

Here should be some description text taken from locales.

Comment 1

[Joey Minta]

I tend to feel that this bug could just be marked WONTFIX, becasue the
description text is certainly temporary.  It will be removed once time zones are
implemented, and I don't see much point in having all the translators deal with it.

Comment 2

[Simon Paquet [:sipaq]]

Taking and confirming. Patch coming on the weekend.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v1

This fixes the issue and does some small additional whitespace cleanup. 

The file timezonePrefs.xul has DOS line endings though (in CVS) which should
also be fixed at checkin time. I didn't include this in my patch, because then
the patch would be unreadable.

Comment 4

[Mostafa Hosseini]

Comment on attachment 183717 [details] [diff] [review]
Patch v1

r=mostafah
Thanks for the patch.
I'll check this in and then remove the DOS line endings in another commit

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!