273414 - Netscape wintools sections is misleading

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: General, enhancement)

Description

[John Woodell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

'Unpack the zip file into a temporary directory'

When this is the desktop, the installer won't work. I'm guessing that
this is because the path has spaces it it. Running install created
directories in the %MOZ_TOOLS%, but no files.

'set MOZ_TOOLS to the directory you want the build tools installed'

It seems like the script should just put it there. It is really confusing that
you have all these names flying around: wintools, buildtools, moztools, etc.

'...should not be inside your cygwin installation directory'

Another reason just to put it in a standard locaton.

'This batch script will install the files into %MOZ_TOOLS%/bin'

Not clear why it needs to do this at all. 
Users need to go back and delete the temp copy.

Reproducible: Always
Steps to Reproduce:




I"m going to look at the install.bat, and think about making an installer.
I am familiar with inno, but I suppose nsis could work also. 

I think an installer for MOZ_TOOLS would be nice because of all the other
components that are installed (like gygwin, wincvs, etc) it is 'hokey'.

It seems like the installer could also spit out a environment bat file
that sets all the paths, and calls vcvars32.bat for you, etc.

I'll make some fancy artwork... maybe this would be a good time 
to rename it moz_tools (not Netscape wintools).

Maybe the final bat that is called could do a quick check, to see that
you have all the required goodies from cygwin and the processor pack stuff.

Comment 1

[Brian Haskin (Janzert)]

What version of windows are you seeing this on?

It works for me with windows xp here.

Brian

Comment 2

[John Woodell]

Windoes XP Home Edition

Comment 3

[Brian Haskin (Janzert)]

Ok, I can't reproduce it yet under windows xp. Could you post the actual full
path to your desktop?

Also keep in mind if you want to make an installer to replace wintools.zip, it
needs to run on all the windows platforms that mozilla can be built on (sounds
like a job for xpinstall ;) ). Also the things included in wintools are in the
process of being changed. Bug #274221 has a fairly complete list of the bugs
that show what changes need to be made. bsmedburg would be the one to approve an
installer, but I think it probably would be accepted if it did the things listed
above.

Brian

Comment 4

[Brian Haskin (Janzert)]

windows xp -> windows xp pro

Brian

Comment 5

[John Woodell]

I just reproduced this once more...

from http://www.mozilla.org/build/win32.html,
click to download wintools.zip... to the desktop.

Extract with winzip to desktop, now e I have a
buildtools folder on my desktop.

Double-clicking this fails because I need to set MOZ_TOOLS=C:\moztools
C:\Documents and Settings\woodie\Desktop\buildtools\windows\install.bat

Open cmd, set the var, and drap the bat into the cmd window.
This creates the directories, but not any files...

C:\Documents and Settings\woodie>set MOZ_TOOLS=C:\moztools

C:\Documents and Settings\woodie>"C:\Documents and Settings\woodie\Desktop\build
tools\windows\install.bat"

MOZ_TOOLS is set to C:\moztools

copying exes and dlls to C:\moztools\bin
copying include files to C:\moztools\include
copying include files to C:\moztools\include\libIDL
copying lib files to C:\moztools\lib

done copying

make sure that MOZ_TOOLS\bin is on your path

Comment 6

[John Woodell]

OK, the having buildtools on the desktop is not the problem.
but you MUST cd to the directory where install.bat lives,
so the files will be copied. This works...

C:\>cd "C:\Documents and Settings\woodie\Desktop\buildtools\windows\"

C:\Documents and Settings\woodie\Desktop\buildtools\windows>install.bat

MOZ_TOOLS is set to C:\moztools

copying exes and dlls to C:\moztools\bin
copying include files to C:\moztools\include
copying include files to C:\moztools\include\libIDL
copying lib files to C:\moztools\lib

done copying

make sure that MOZ_TOOLS\bin is on your path

Comment 7

[Brian Haskin (Janzert)]

Ahh, yes that would do it.

install.bat makes the assumption it's run from the directory it comes in.

Brian

P.S. Interesting, never knew you could drag and drop a file into a command prompt.

Comment 8

[John Woodell]

(In reply to comment #7)

You can set environment variables in a command prompt, 
then drag a bat or exe into the window to run it with
those custom variables.

Comment 9

[John Woodell]

Here is my take at a moztools installer:
http://www.netpress.com/moztools/moztools.exe

Comment 10

[Brian Haskin (Janzert)]

Pretty. 

But after talking to bsmedberg an installer won't be accepted to replace
wintools.zip. It's just overkill for the problem. I also wonder if it wouldn't
lead to more support and compatibility problems in the future.

Brian

Comment 11

[John Woodell]

I just noticed that the 'Building Mozilla on... Windows' page has been updated.

Now it completely rocks. Good work!