273440 - caICSService produces invalid ics

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

calICSService produces this:
BEGIN:VCALENDAR
VERSION
 ;VALUE=STRING
 :2.0
METHOD
 ;VALUE=INTEGER
 :10012
END:VCALENDAR

expected:
BEGIN:VCALENDAR
VERSION:2.0
METHOD:PUBLISH
END:VCALENDAR

I'm not sure about the version part, but the method part isn't very interop
compatible like this. the number 10012 is something internal to libical.

testcase:

const calIICSService = Components.interfaces.calIICSService;
const calIIcalComponent = Components.interfaces.calIIcalComponent;
var icsServ = Components.classes["@mozilla.org/calendar/ics-service;1"]
                        .createInstance(Components.interfaces.calIICSService);
var calComp = icsServ.createIcalComponent(calIIcalComponent.VCALENDAR_COMPONENT);
calComp.version = "2.0";
calComp.method = calIIcalComponent.METHOD_PUBLISH;
dump(calComp.serializeToICS());

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: possible patch

I'm not too happy about the naming etc in the patch, but it should produce
valid ics.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

With the current libical it should produce:
BEGIN:VCALENDAR
VERSION
 :2.0
METHOD
 :PUBLISH
END:VCALENDAR
Just a slight difference in whitespace.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 168060 [details] [diff] [review]
possible patch

Looks fine to me.  Please land at your earliest convenience!

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.