most gopher-*.gif images are unused

RESOLVED FIXED in mozilla1.9beta1

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
14 years ago
11 years ago

People

(Reporter: dbaron, Assigned: dao)

Tracking

Trunk
mozilla1.9beta1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
Most of the gopher-*.gif images in layout/html/base/src/ (soon to be moved in
bug 272151) have been unused since bug 83774 landed.  Note that the static
function in mimefilt.cpp in the following is never called:

http://lxr.mozilla.org/seamonkey/search?string=gopher-

So it seems we use only gopher-image.gif, gopher-unknown.gif, and gopher-menu.gif
hmm, note that there's a bug requesting that we use them for ftp/local dir listings

Comment 2

13 years ago
Let's use this bug to:
* Copy the used images to chrome://global/skin (or use new ones...)
* Use Bug 269017 to make FTP and dirlistings use the chrome based icons
* Delete the all these 'gopher' images from /gre after 269017 has been committed
and verified
Depends on: 269017

Comment 3

11 years ago
Updated bug 269017: directory listings generated by nsIndexedToHTML to use a stylesheet so that this output can be styled.
After that has been applied, the /gre/res/html/gopher- should be removed.
(Assignee)

Updated

11 years ago
Depends on: 294800
No longer depends on: 269017
(Assignee)

Updated

11 years ago
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9-
(Assignee)

Comment 4

11 years ago
Created attachment 283549 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #283549 - Flags: review?(dbaron)
(Reporter)

Comment 5

11 years ago
Could you summarize what this patch is doing?  Why is it ok to remove the things that you're removing?
(Assignee)

Comment 6

11 years ago
Because Gecko doesn't use them -- isn't that what this bug is about? What was your goal when you filed this if not to remove those files?
(Reporter)

Comment 7

11 years ago
Comment on attachment 283549 [details] [diff] [review]
patch

Sorry, misread some of the mailnews changes the first time through; r=dbaron.
Attachment #283549 - Flags: review?(dbaron) → review+
(Assignee)

Updated

11 years ago
Attachment #283549 - Flags: superreview?(dbaron)
Attachment #283549 - Flags: approval1.9?
(Reporter)

Comment 8

11 years ago
Comment on attachment 283549 [details] [diff] [review]
patch

sr=dbaron
Attachment #283549 - Flags: superreview?(dbaron) → superreview+
(Reporter)

Comment 9

11 years ago
Comment on attachment 283549 [details] [diff] [review]
patch

a1.9=dbaron
Attachment #283549 - Flags: approval1.9? → approval1.9+
Checking in embedding/config/basebrowser-installer-win.pkg;
/cvsroot/mozilla/embedding/config/basebrowser-installer-win.pkg,v  <--  basebrowser-installer-win.pkg
new revision: 1.45; previous revision: 1.44
done
Checking in embedding/config/basebrowser-win;
/cvsroot/mozilla/embedding/config/basebrowser-win,v  <--  basebrowser-win
new revision: 1.111; previous revision: 1.110
done
Checking in layout/build/layout.pkg;
/cvsroot/mozilla/layout/build/layout.pkg,v  <--  layout.pkg
new revision: 1.11; previous revision: 1.10
done
Checking in layout/html/tests/block/bugs/17636.html;
/cvsroot/mozilla/layout/html/tests/block/bugs/17636.html,v  <--  17636.html
new revision: 1.5; previous revision: 1.4
done
Checking in mailnews/mime/src/mimefilt.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimefilt.cpp,v  <--  mimefilt.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in mailnews/mime/src/mimemoz2.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimemoz2.cpp,v  <--  mimemoz2.cpp
new revision: 1.233; previous revision: 1.232
done
Checking in layout/generic/Makefile.in;
/cvsroot/mozilla/layout/generic/Makefile.in,v  <--  Makefile.in
new revision: 1.30; previous revision: 1.29
done
Removing layout/generic/gopher-audio.gif;
/cvsroot/mozilla/layout/generic/gopher-audio.gif,v  <--  gopher-audio.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-binary.gif;
/cvsroot/mozilla/layout/generic/gopher-binary.gif,v  <--  gopher-binary.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-find.gif;
/cvsroot/mozilla/layout/generic/gopher-find.gif,v  <--  gopher-find.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-image.gif;
/cvsroot/mozilla/layout/generic/gopher-image.gif,v  <--  gopher-image.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-menu.gif;
/cvsroot/mozilla/layout/generic/gopher-menu.gif,v  <--  gopher-menu.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-movie.gif;
/cvsroot/mozilla/layout/generic/gopher-movie.gif,v  <--  gopher-movie.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-sound.gif;
/cvsroot/mozilla/layout/generic/gopher-sound.gif,v  <--  gopher-sound.gif
new revision: delete; previous revision: 3.2
done
Removing layout/generic/gopher-telnet.gif;
/cvsroot/mozilla/layout/generic/gopher-telnet.gif,v  <--  gopher-telnet.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-text.gif;
/cvsroot/mozilla/layout/generic/gopher-text.gif,v  <--  gopher-text.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-unknown.gif;
/cvsroot/mozilla/layout/generic/gopher-unknown.gif,v  <--  gopher-unknown.gif
new revision: delete; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Depends on: 404327
You need to log in before you can comment on or make changes to this bug.