273459 - most gopher-*.gif images are unused

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Most of the gopher-*.gif images in layout/html/base/src/ (soon to be moved in
bug 272151) have been unused since bug 83774 landed.  Note that the static
function in mimefilt.cpp in the following is never called:

http://lxr.mozilla.org/seamonkey/search?string=gopher-

So it seems we use only gopher-image.gif, gopher-unknown.gif, and gopher-menu.gif

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, note that there's a bug requesting that we use them for ftp/local dir listings

Comment 2

[Alfred Kayser]

Let's use this bug to:
* Copy the used images to chrome://global/skin (or use new ones...)
* Use Bug 269017 to make FTP and dirlistings use the chrome based icons
* Delete the all these 'gopher' images from /gre after 269017 has been committed
and verified

Comment 3

[Alfred Kayser]

Updated bug 269017: directory listings generated by nsIndexedToHTML to use a stylesheet so that this output can be styled.
After that has been applied, the /gre/res/html/gopher- should be removed.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Could you summarize what this patch is doing?  Why is it ok to remove the things that you're removing?

Comment 6

[Dão Gottwald [:dao]]

Because Gecko doesn't use them -- isn't that what this bug is about? What was your goal when you filed this if not to remove those files?

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 283549 [details] [diff] [review]
patch

Sorry, misread some of the mailnews changes the first time through; r=dbaron.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 283549 [details] [diff] [review]
patch

sr=dbaron

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 283549 [details] [diff] [review]
patch

a1.9=dbaron

Comment 10

[Reed Loden [:reed]]

Checking in embedding/config/basebrowser-installer-win.pkg;
/cvsroot/mozilla/embedding/config/basebrowser-installer-win.pkg,v  <--  basebrowser-installer-win.pkg
new revision: 1.45; previous revision: 1.44
done
Checking in embedding/config/basebrowser-win;
/cvsroot/mozilla/embedding/config/basebrowser-win,v  <--  basebrowser-win
new revision: 1.111; previous revision: 1.110
done
Checking in layout/build/layout.pkg;
/cvsroot/mozilla/layout/build/layout.pkg,v  <--  layout.pkg
new revision: 1.11; previous revision: 1.10
done
Checking in layout/html/tests/block/bugs/17636.html;
/cvsroot/mozilla/layout/html/tests/block/bugs/17636.html,v  <--  17636.html
new revision: 1.5; previous revision: 1.4
done
Checking in mailnews/mime/src/mimefilt.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimefilt.cpp,v  <--  mimefilt.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in mailnews/mime/src/mimemoz2.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimemoz2.cpp,v  <--  mimemoz2.cpp
new revision: 1.233; previous revision: 1.232
done
Checking in layout/generic/Makefile.in;
/cvsroot/mozilla/layout/generic/Makefile.in,v  <--  Makefile.in
new revision: 1.30; previous revision: 1.29
done
Removing layout/generic/gopher-audio.gif;
/cvsroot/mozilla/layout/generic/gopher-audio.gif,v  <--  gopher-audio.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-binary.gif;
/cvsroot/mozilla/layout/generic/gopher-binary.gif,v  <--  gopher-binary.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-find.gif;
/cvsroot/mozilla/layout/generic/gopher-find.gif,v  <--  gopher-find.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-image.gif;
/cvsroot/mozilla/layout/generic/gopher-image.gif,v  <--  gopher-image.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-menu.gif;
/cvsroot/mozilla/layout/generic/gopher-menu.gif,v  <--  gopher-menu.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-movie.gif;
/cvsroot/mozilla/layout/generic/gopher-movie.gif,v  <--  gopher-movie.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-sound.gif;
/cvsroot/mozilla/layout/generic/gopher-sound.gif,v  <--  gopher-sound.gif
new revision: delete; previous revision: 3.2
done
Removing layout/generic/gopher-telnet.gif;
/cvsroot/mozilla/layout/generic/gopher-telnet.gif,v  <--  gopher-telnet.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-text.gif;
/cvsroot/mozilla/layout/generic/gopher-text.gif,v  <--  gopher-text.gif
new revision: delete; previous revision: 1.2
done
Removing layout/generic/gopher-unknown.gif;
/cvsroot/mozilla/layout/generic/gopher-unknown.gif,v  <--  gopher-unknown.gif
new revision: delete; previous revision: 1.2
done