273483 - param(sendmailnow) information is very out-of-date and not helpful.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Shane H. W. Travis]

Talking with Dave about what 'sendmailnow' was supposed to do, and the 
information on the 'defparams.cgi' page is so far off the mark as almost to be 
dangerous.

Updating it to reflect what Dave told me.

Comment 1

[Shane H. W. Travis]

Attachment: Code patch for 2.18 and tip

so simple it's almost a documentation bug. :)

Comment 2

[Shane H. W. Travis]

Attachment: Code patch for 2.18 and tip, take 2

It's always the little things -- like periods for concatenation -- that mess
you up. D'oh!

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 168101 [details] [diff] [review]
Code patch for 2.18 and tip, take 2

>+   desc => 'Sites using older versions of \'sendmail\' (anything up to ' .
>+           '8.12) can achieve a significant performance increase in the ' .

Should say "anything older than 8.12" or "anything up to 8.11.x" for clarity
here, lest anything think 8.12 is included :)

>+           'UI -- at the cost of delaying the sending of mail -- by ' .
>+           'enabling this parameter. Sites using \'sendmail\' 8.12 or ' .

"by disabling this parameter"

The rest looks good, this is a VAST improvement. :)

Comment 4

[Shane H. W. Travis]

Attachment: Code patch for 2.18 and tip, take 3

Well, I did say 'up to' and not 'up to and including'... but I agree that this
way is clearer.

As for the enable/disable... Umm... I meant to do that. It was a test. Yeah...
that's the ticket...

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 168102 [details] [diff] [review]
Code patch for 2.18 and tip, take 3

Looks good.  I think this is worthy of going on the 2.16 branch as well, but
the format of the defparams.pl file is different, so it'll need to be
backported.

Comment 6

[Shane H. W. Travis]

Attachment: Code patch for 2.16

Ask, and ye shall receive; 2.16 patch attached.

Comment 7

[Shane H. W. Travis]

Attachment: Code patch for 2.16, take 2

Bah, got the diffs in the wrong direction, so they probably wouldn't apply
cleanly. This one works correctly. Just goes to prove the old saying; the
hurrier I go, the behinder I get.

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 168223 [details] [diff] [review]
Code patch for 2.16, take 2

nit: the escaping of the quotes around 'sendmail' is unnecessary because the
string itself is using a different quote character.

otherwise r=justdave

Comment 9

[Vlad Dascalu]

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.140; previous revision: 1.139
done

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.128.2.3; previous revision: 1.128.2.2
done

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.73.2.10; previous revision: 1.73.2.9
done