273493 - fix: icons for firefox windows

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Ports: Qt, defect)

Description

[Michal Ceresna]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)

this fix implements setIcon, setDefaultIcon methods, plus some others

Reproducible: Always
Steps to Reproduce:
1. copy default.xpm into dist/bin/chrome/icons/
2. start dist/bin/firefox
window gets an icon

Comment 1

[Michal Ceresna]

Attachment: missing methods from nsBaseWidget

Comment 2

[Zack Rusin]

Oh, great. One issue I have with the current implementation is that those  
methods are nsWindow specific so there's no reason why we should be keeping 
them in the base class. Could you perhaps move them to nsWindow? 

Comment 3

[Michal Ceresna]

(In reply to comment #2) 
> those methods are nsWindow specific ... 
> Could you perhaps move them to nsWindow?  
just wanted to keep the code similar to the gtk2 version 
for easier maintenance 
 

Comment 4

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 5

[Takanori MATSUURA]

This bug lies at rest in the graveyard.