273496 - pressing 'get new messages' asks to send unsent messages when going online

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla 1.7.3

I have selected the pref 'when going online, DO NOT automatically send unsent
messages (and don't ask)'.

Reproducible: Always
Steps to Reproduce:
1.Be offline
2.Prepare a message
3.Press 'get new messages'
4.Moz asks if you want to go online - yes

Actual Results:  
Then it asks if you want to send unsent messages.

Expected Results:  
Do not ask me about that and proceed to download new mail without sending anything.

Comment 1

[Frank Wein [:mcsmurf]]

Confirming with current trunk build. Bug 235406 might be a bit related here.

Comment 2

[Mike Cowperthwaite]

CC'ing Magnus, who fixed a similar problem at bug 274280.

Comment 3

[Magnus Melin [:mkmelin]]

This is WFM on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070105 Thunderbird/2.0b1 ID:2007010503

Comment 4

[OstGote!]

I can confirm this bug for SeaMonkey on Win XP. For both versions I will be prompted for sending the unsent msgs too if the option is set to no/ask. So I guess this special behavior is SM specific.

SM trunk build 2006122108
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061221 SeaMonkey/1.5a
SM 1.8.1 branch build 2006122101
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20061221 SeaMonkey/1.1

Comment 5

[Mike Cowperthwaite]

I reproduced this also -- 2b1-0105, Win2K -- before CC'ing you, Magnus.

Comment 6

[OstGote!]

Could this be Windows specific? Someone should test this with SM on Linux or others.

Comment 7

[Magnus Melin [:mkmelin]]

Sorry, I can reproduce it now... don't know why I couldn't yesterday.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (thunderbird)

This fixes is for thunderbird.

Comment 9

[Scott MacGregor]

Comment on attachment 250961 [details] [diff] [review]
proposed fix (thunderbird)

cool!

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (thunderbird branch)

Attaching this since the patch does not apply cleanly to branch. (And no, I have no idea why the three first hunks are included in this diff - they look identical to me.)

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/base/content/mail-offline.js 	1.7
mozilla/mail/base/content/msgMail3PaneWindow.js 	1.114

Comment 12

[OstGote!]

This is (also) a Suite bug and the patch is only for Thunderbird, so it isn't really fixed. Magnus, are you going to fix SM as well? I hope so. :-) Otherwise should the bug reopened.

Comment 13

[Magnus Melin [:mkmelin]]

Yes, seamonkey patch coming up. Moving to Core so i can ask tb2 approval...

Comment 14

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (seamonkey)

Scott, do you want to r/sr the sm part too?

Comment 15

[Mike Cowperthwaite]

I can verify the patch works on TB trunk.  I guess the branch patch is still not checked in...?

Comment 16

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/base/content/mail-offline.js 	1.3.2.5
mozilla/mail/base/content/msgMail3PaneWindow.js 	1.70.2.42

Comment 17

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.2 using the steps to reproduce from comment#1. 

Using: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20070207 Thunderbird/2.0pre ID:2007020704

Comment 18

[Mike Cowperthwaite]

Also v with TB 2b2-0207, Win2K.

Comment 19

[OstGote!]

SM patch still not checked in. :-/

Comment 20

[Magnus Melin [:mkmelin]]

No, waiting for Karsten's review...

Comment 21

[Karsten Düsterloh]

Comment on attachment 251208 [details] [diff] [review]
proposed fix (seamonkey)

>+      switch (sendUnsentPref) {
>+      case 0: // ask
>+        sendUnsent = gPromptService.confirmEx(window, 

Prevalent bracing style in this file is 'aligned curly braces', so the '{' has to go onto the next line and the case branches incl. their content has to go one indentation level deeper.

r=me with that.

Thanks for remembering about us, Magnus! :)

Comment 22

[Magnus Melin [:mkmelin]]

Attachment: proposed fix (seamonkey) v2 - for checkin

Review comments addressed.

Comment 23

[Nickolay_Ponomarev]

mozilla/mailnews/base/resources/content/mailWindowOverlay.js   1.251