273684 - Can't expose right-side elements in Preference dialog

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

The right-side elements in Preference dialog is inside a set of groupbox, which
has no state and can't be accessed by GOK.

Comment 1

[Louie Zhao]

Attachment: patch v1

Give groupbox accessible states.

Comment 2

[Aaron Leventhal]

Comment on attachment 168195 [details] [diff] [review]
patch v1

It's not that the groupbox has no state, but it has all the state flags
cleared.

This patch is not right. It makes the groupbox have STATE_FOCUSABLE. A groupbox
itself cannot receive focus. Only the children within it can.

Comment 3

[Aaron Leventhal]

Is GOK not walking into items that don't have STATE_FOCUSABLE set?

In one sense a groupbox is like a table. A table is not focusable but it can
have links or form controls inside of it that are focusable. However, we still
wouldn't want to set the focusable state on the table.

Comment 4

[Louie Zhao]

Attachment: patch v2

accessible object can be accessed by gok when it has "STATE_SHOWING" and
"STATE_VISIBLE". So need to export such state for groupbox. Meanwhile
"STATE_FOCUSABLE" shouldn't be exported because groupbox can't be focused.

Comment 5

[Louie Zhao]

patch already in trunk.