273698 - removing an item from sites/cookie exceptions list leaves a blank line in the tree

Status: VERIFIED WORKSFORME

(Firefox :: Settings UI, defect, P3)

Description

[Steffen Wilberg]

Spin-off from bug 272678 comment 10.

This happens with Firefox 1.0 as well as trunk.

1. Open Options->Web Features->Allowed Sites.
2. If the exceptions dialog is empty, create a few items.
3. Delete the last item.

Actual Result:
The blank line after the last item is selected.

Expected Result:
The last item is selected.


The js console displays this:
Error: setting a property that has only a getter
Source File: chrome://browser/content/cookieviewer/treeUtils.js
Line: 43

And then this error every time you mouse over the blank line:
Error: gPermissionManager._addedPermissions[aRow] has no properties
Source File: chrome://browser/content/cookieviewer/CookieExceptions.js
Line: 32
(and line 34)

Comment 1

[Steffen Wilberg]

The reason is that treeUtils.js does this:
  view.rowCount -= k - j;
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/cookieviewer/content/treeUtils.js&mark=64#43

But CookieExceptions.js only provides _rowCount, not rowCount. I don't know what
the tree code does, or why CookieExceptions.js uses _rowCount, but this bug can
be fixed by changing all instances of _rowCount to rowCount in
CookieExceptions.js, or even by deleting the view.rowCount -= k - j; line in
treeUtils.js. Maybe the tree widget refactoring bug 221619 made it obsolete?

Comment 2

[Phil Ringnalda (:philor)]

*** Bug 271671 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 270341 has been marked as a duplicate of this bug. ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: Add the setter

I think the safest route is to just provide the public setter. I haven't
actually gotten deep into the tree code but this fixes it and shouldn't break
anything. rowCount is apparently used at
http://lxr.mozilla.org/mozilla/source/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp#1413
to redisplay the tree, or something of the sort. Is there someone familiar with
the tree code that could advise?

This should also fix the DeleteAll function, which according to
http://lxr.mozilla.org/mozilla/source/browser/components/cookieviewer/content/treeUtils.js#32
should probably be broken.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The checkin from bug 215656 introduced the error.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 281998 has been marked as a duplicate of this bug. ***

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This was fixed by Ben's new pref dialog.

Comment 8

[djpohly]

*** Bug 295385 has been marked as a duplicate of this bug. ***

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 305856 has been marked as a duplicate of this bug. ***

Comment 10

[:Gavin Sharp [email: [e-mail]]]

*** Bug 306923 has been marked as a duplicate of this bug. ***

Comment 11

[Adam Guthrie]

*** Bug 277629 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change