Last Comment Bug 273793 - "Attached" message/rfc822 not shown in attachment panel, when Inline Display is off
: "Attached" message/rfc822 not shown in attachment panel, when Inline Display ...
Status: RESOLVED FIXED
: testcase
Product: MailNews Core
Classification: Components
Component: Attachments (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Thunderbird 14.0
Assigned To: Jim Porter (:squib)
:
:
Mentors:
Depends on:
Blocks: 269826
  Show dependency treegraph
 
Reported: 2004-12-08 13:40 PST by seschu_mail2
Modified: 2012-04-13 17:49 PDT (History)
7 users (show)
squibblyflabbetydoo: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Mail with attachment (3.43 KB, message/rfc822)
2005-02-16 14:24 PST, seschu_mail2
no flags Details
Fix this, and count the size of RFC 822 bodies (6.50 KB, patch)
2012-04-08 20:12 PDT, Jim Porter (:squib)
mozilla: review+
Details | Diff | Splinter Review

Description seschu_mail2 2004-12-08 13:40:06 PST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Thunderbird Version 1.0 (20041206)

If a mail contains an email (eml file) as attachment and the "Show inline" from
the "View" menu is NOT activated the attachment (the mail) is not displayed at all. 

Reproducible: Always
Steps to Reproduce:
1. Send a mail with email as attachment to you
2. Uncheck the "Show inline" from the "View" menu
3. Open the mail



Expected Results:  
The attachment field should be present to open it
Comment 1 Mike Cowperthwaite 2004-12-09 12:03:00 PST
I am unable to reproduce this problem with TB 1.0, Win2K -- messages with an 
attached email message show the attachment pane, with the attachment visible 
therein.
Comment 2 Mike Cowperthwaite 2005-01-10 15:27:07 PST
No response from reporter; =>WFM
Comment 3 Mike Cowperthwaite 2005-02-16 13:41:58 PST
Reopening; reviewing my email, I see that I did receive a response from 
reporter.  Please do not send mail in order to respond to queries in a bug; use 
the bug's webpage.

I could not get your sample message to work correctly, probably due to problems 
copying and pasting.  If you still have that message on hand, please do the 
following:  Save it to disk as a .EML file; then attach the file to this bug 
using the Create New Attachment link above.
Comment 4 seschu_mail2 2005-02-16 14:24:39 PST
Created attachment 174524 [details]
Mail with attachment

Here is another file that shows the describes bug. I confirmed this mail to
still contain the failure ;-(
Comment 5 Mike Cowperthwaite 2005-02-17 07:23:59 PST
OK, I see this.  Reproduced with TB 1.0, Moz 1.8b-0120, Win2K.

The issue is seen because the message has this:
  Content-Type: message/rfc822
After the headers of the message stop, the headers of the "attached" message 
start.  This is unlike normal messages with attachments, whose type is typically 
multipart/mixed; in this case, the message body *is* the attachment.

With Display Attachments Inline turned on, the display is a blank body, followed 
by an attachment divider, followed by the message/rfc822 part as it would be 
seen as a regular attachment; and the icon appears in the attachment panel to 
allow the item to be accessed.

But with Display Attachment Inline turned *off*, the message is completely 
blank, with no attachment panel -- just as reported.

Compare to attachment 61294 [details] (from bug 2920) -- there, the top-level Content-Type 
is image/jpeg.  If Display Attachments Inline is off, the item does appear in 
the attachment panel.

Moving this to Core:Attachments, but I suppose it might be a MIME issue as well.

See also bug 234980.
Comment 6 (not reading, please use seth@sspitzer.org instead) 2007-06-21 15:37:59 PDT
sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.
Comment 7 [:Aureliano Buendía] 2010-04-11 05:39:14 PDT
*** Bug 381544 has been marked as a duplicate of this bug. ***
Comment 8 [:Aureliano Buendía] 2010-04-11 05:41:49 PDT
Confirmed also with latest 

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4pre) Gecko/20100410 Lightning/1.0b2pre Lanikai/3.1b2pre ID:20100410032217

It's very annoying: any chance to fix it for 3.1 relase?

Set request to mark it wanted-thunderbird3.1
Comment 9 Doug Hockin 2010-07-03 14:35:46 PDT
I have received exactly this kind of email from Delta airlines and have the
same problem.

If I have "Display attachments inline" unchecked, the message body is
completely blank and there is no indication at _all_ that there is an
attachment with this email.

In general I don't want to show attachments inline and there should be
something in the message header area that indicates there are attachments not
displayed -- there should be a list of the attachments and I should be able to
open them each individually.
Comment 10 Mark Banner (:standard8, limited time in Dec) 2010-07-13 05:01:46 PDT
(In reply to comment #8)
> Set request to mark it wanted-thunderbird3.1

Not going to want for a specific release.
Comment 11 Jim Porter (:squib) 2012-03-19 02:50:30 PDT
Taking. This is easy enough to fix, but I'm going to write tests before I upload my patch.
Comment 12 Jim Porter (:squib) 2012-04-08 20:12:47 PDT
Created attachment 613217 [details] [diff] [review]
Fix this, and count the size of RFC 822 bodies

This patch fixes the issue in the bug, and also properly counts the size of the RFC 822 body part. You'll need to apply the patch in bug 736881 first for the tests to pass.
Comment 13 Jim Porter (:squib) 2012-04-13 17:49:53 PDT
Checked in: http://hg.mozilla.org/comm-central/rev/e84b162968c7

Note You need to log in before you can comment on or make changes to this bug.