Closed Bug 273808 Opened 20 years ago Closed 20 years ago

nsViewManager::CreateBlendingBuffers should null mBlender if it fails to init

Categories

(Core :: Web Painting, defect)

Product:
Core
Component:
Web Painting
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

Attachments

(1 file)

null mblender when init fails
748 bytes, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review 
the current code will result in a second call to CreateBlendingBuffers 
presuming that mBlender is happy and then when callers try to use mBlender 
because the rest of CreateBlendingBuffers succeeds, they'd be fairly unhappy.

    
  

        Attachment #168253 -
        Flags: superreview?(roc)

        Attachment #168253 -
        Flags: review?(roc)

        Attachment #168253 -
        Flags: superreview?(roc)

        Attachment #168253 -
        Flags: superreview+

        Attachment #168253 -
        Flags: review?(roc)

        Attachment #168253 -
        Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
mozilla/view/src/nsViewManager.cpp 	3.376
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: Layout: View Rendering → Layout: Web Painting

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: