Closed
Bug 273829
Opened 20 years ago
Closed 20 years ago
remove nsFormControlHelper::GetLocalizedString
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: perf, Whiteboard: [patch])
Attachments
(1 file, 2 obsolete files)
|
45.40 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
We should remove nsFormControlHelper::GetLocalizedString in favor of faster (caches the string bundles) code in nsContentUtils.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Comment 2•20 years ago
|
||
I got a little carried away and converted nsDocumentViewer, nsPrintEngine, and nsFormSubmission as well.
Attachment #168263 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•20 years ago
|
||
Attachment #168265 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta
|
|
Assignee | |
Updated•20 years ago
|
Attachment #168275 -
Flags: superreview?(bryner)
Attachment #168275 -
Flags: review?(bryner)
|
||
Updated•20 years ago
|
Attachment #168275 -
Flags: superreview?(bryner)
Attachment #168275 -
Flags: superreview+
Attachment #168275 -
Flags: review?(bryner)
Attachment #168275 -
Flags: review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fix checked in, 2004-12-17 12:40 -0800.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 5•20 years ago
|
||
Why do nsContentUtils::Get/FormatLocalizesString not take an nsXPIDLString& ?
|
|
Assignee | |
Comment 6•20 years ago
|
||
I guess it could, though I don't like them. I was thinking at the time that it would share the buffer, but with the new string code it actually wouldn't.
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•