273842 - spaces in stack frame signatures should be  

Status: RESOLVED WONTFIX

(mozilla.org :: Talkback Server & Webtool, task)

Description

[timeless]

The top frame of tb2425673 is:

<span class=stack><a
href='http://bugzilla.mozilla.org/buglist.cgi?query_format=&long_desc_type=substring&long_desc=XPCWrappedNative::CallMethodXPCCallContext&amp;,&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0='>XPCWrappedNative::CallMethod(XPCCallContext&amp;,
XPCWrappedNative::CallMode)()</a></span>&nbsp&nbsp<span class=source><a
href='http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp&mark=265&rev=AVIARY_1_0_20040515_BRANCH#265'>[/builds/tinderbox/firefox-1.0/Linux_2.4.20-28.8_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 265]</a></span><br>

the rendering is:
XPCWrappedNative::CallMethod(XPCCallContext&, <br>
XPCWrappedNative::CallMode)()[/builds/tinderbox/firefox-1.0/Linux_2.4.20-28.8_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 265]

which kinda sucks, since it looks like XPCWrappedNative::CallMode is a function
(it isn't, it's a type) and it looks like the line number for
XPCWrappedNative::CallMethod was lost (it isn't, it wrapped to the next line).

Comment 1

[Jay Patel [:jay]]

Attachment: getFrameLink function

This is a side effect of how I had to split the stack frames in order to create
the bugzilla and bonsai links.	I tried a few different things but what I have
now is the best I could come up with. 

I'll revisit this problem and see if there is anything I can do differently. I
also need to look into fixing bug 245942 while I'm in there. 

I have attached the function that processes the stack frames...take a look and
let me know if you have any ideas.  It's pretty messy, but it works...kinda.

Comment 2

[timeless]

Comment on attachment 168373 [details]
getFrameLink function

>			String [] thisfile = thisframe[1].split("/mozilla/");
>			if (thisfile.length == 2) {
should check >=2 not ==2. there's a mozilla/ directory in xpinstall among
others

Comment 3

[Jay Patel [:jay]]

Adding [quicksearch 2.0] to whiteboard to track features/fixes I hope to get
into the next version of the Talkback query tools.

Comment 4

[Daniel Veditz [:dveditz] (OOO: back Aug 26)]

We have not used Talkback in years and it is not longer maintained. Closing bugs.