273864 - Bad examples of SSL_ForceHandshake in our commands

Status: RESOLVED WONTFIX

(NSS :: Tools, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

As it is presently implemenmted, SSL_ForceHandshake discards any previously
received appliation data each time it is called.  Consequently, the right
way to use it is to call SSL_DataPending on the socket prior to each call
to SSL_ForceHandshake.  Selfserv uses SSL_ForceHandshake, but does not 
use SSL_DataPending along with it, and thus sets a very poor example.

It's been OK because selfserv discards all the http request's POST data 
anyway, so selfserv isn't hurt if ForceHandshake discards some of it 
earlier than it otherwise would be.  But in the interest of exemplary 
test programs, selfserv (and any other programs that use ForceHandshake)
should do it right.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I think the right thing to do is to fix Bug 273861 instead.
That is, fix SSL_ForceHandshake to not discard received data first.
So, no change to the users of SSL_ForceHandshake will be needed.