2739 - Abort error on text search

Status: VERIFIED FIXED

(Webtools Graveyard :: MXR, defect, P2)

Description

[tenthumbs]

Do a text search on "URL_s->expire" from the webpage and get
"** Aborting: Illegal characters in HTTP-parameters." error.
Both Netscape and Lynx produce the same error so it's not a
client problem. Both clients use
http://cvs-mirror.mozilla.org/webtools/lxr/search?string=URL_s-%3Eexpire
as a URL.

Comment 1

[Dawn Endico]

lxr washes out characters that could cause trouble with open().
That's fine for the source script but its overkill for glipse searches.
Need to change where http_wash is called.

Comment 2

[leger]

Setting all current Open/Normal to M4.

Comment 3

[leger]

Clearing "M" field since Webtools product is not used for 5.0 specific project
bug metrics and will mess up our queries on milestones.

Comment 4

[Dawn Endico]

*** Bug 13304 has been marked as a duplicate of this bug. ***

Comment 5

[Dawn Endico]

*** Bug 12946 has been marked as a duplicate of this bug. ***

Comment 6

[Dawn Endico]

*** Bug 13056 has been marked as a duplicate of this bug. ***

Comment 7

[Dawn Endico]

LXR no longer tries to wash out metacharacters from glimpse searches.
per simon's request, by default it treats meta characters as literals.
Press a button if you want to do regeps. Changed the docs so they no
longer say to use "\\" to escape metachars. Only one slash is needed.
The docs were written for people typing from the shell prompt.

Comment 8

[Akkana Peck]

The new searches are awesome -- thanks!  But it doesn't always work: for
example, try a text search for
overwriting current primary frame

Comment 9

[Dawn Endico]

The "overwriting primary frame" problem is a duplicate of bug 13874
which I resolved. (glimpse allows a max search string size of 29 characters)
Marking this fixed again.

Comment 10

[timeless]

vrfy fixed
by 1.5 endico%mozilla.org Sep 10 1999
and testing