273961 - nsIProcess.run() causes double execution of the target process

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Giorgio Maone [:ma1]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041208 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041208 Firefox/1.0+

Using nsIProcess.run() to launch an external executable causes this file to run
twice serially.

Reproducible: Always
Steps to Reproduce:
1. On a Windows system execute the following script (adjusting notepad.exe path
if necessary):

const notepad=Components.classes["@mozilla.org/file/local;1"
  ].createInstance(Components.interfaces.nsILocalFile);
notepad.initWithPath("c:\\windows\\notepad.exe")
const process=Components.classes['@mozilla.org/process/util;1'
  ].createInstance(Components.interfaces.nsIProcess);
process.init(notepad);
process.run(true,[],0,{});

2. Wait until Notepad window opens
3. close Notepad window

Actual Results:  
A new Notepad window opened just after I closed the first.

Expected Results:  
nsIProcess should have launched only one instance of Notepad.

Comment 1

[timeless]

regression window:
built on Nov  8 2004 at 05:31:49 - worked
built on Nov 16 2004 at 06:48:30 - failed

Comment 2

[timeless]

built on Nov 10 2004 at 05:17:25 - worked

there are no other builds available from archive.mozilla.org

Comment 3

[timeless]

Attachment: lazy fix - style 1

Comment 4

[timeless]

Attachment: lazy fix - style 2

Comment 5

[timeless]

Attachment: lazy fix - style 2 as a diff against version 1.10

Comment 6

[Johnny Stenback (:jst)]

Attachment: Fix.

Don't include unix process code in the windows build.

Comment 7

[Darin Fisher]

Comment on attachment 168369 [details] [diff] [review]
Fix.

r+sr=darin

Comment 8

[Johnny Stenback (:jst)]

Fixed.

Comment 9

[Johnny Stenback (:jst)]

For the record, my fix is identical to timeless' second fix, didn't realize that
before attaching my own version and landing it. My appologies.