273980 - Add "cite" attribute to the Links tab in Page Info

Status: RESOLVED FIXED

(Firefox :: Page Info Window, enhancement)

Description

[Baron Schwartz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Elements with a "cite" attribute ought to be put into the "Links" tab of the
Page Info dialog.  Elements to which the attribute applies are blockquote, q,
ins, del.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Phil Ringnalda (:philor)]

Attachment: testcase

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Cites are links

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 206754 [details] [diff] [review]
Cites are links

you know, I swear I've reviewed this patch before...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Landed on the trunk and the 1.8 branch for Firefox 2.

trunk:
mozilla/browser/base/content/pageInfo.js;                         1.29;
mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties;  1.5;

1.8:
mozilla/browser/base/content/pageInfo.js;                         1.25.2.3;
mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties; 1.4.10.1;

Comment 5

[Ian Macfarlane]

You should also handle LONGDESC in the links section, rather than just the individual media section, as they are definitely links too.

Comment 6

[Phil Ringnalda (:philor)]

I'd rather see @longdesc in a separate bug, not just because I don't want to reopen a fixed enhancement for a different enhancement, but also because I'm not sure I agree: there's a bit of "@alt as tooltip" to it. There are two ways of viewing an image: render @src or display the thousand words of @longdesc. That seems to make the media tab the right place for it.